$ phpcs --standard=Drupalpractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml field_zip_file/

FILE: C:\Users\SI-001\Downloads\field_zip_file\src\Plugin\Field\FieldFormatter\ZipFileBase.php
----------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------------------------------
67 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
----------------------------------------------------------------------------------------------

Comments

Rakhi Soni created an issue. See original summary.

rakhi soni’s picture

Assigned: rakhi soni » Unassigned
Status: Active » Needs review
StatusFileSize
new1.89 KB

Kindly review patch,,

sourabhjain’s picture

Assigned: Unassigned » sourabhjain

I will review this patch.

sourabhjain’s picture

Status: Needs review » Reviewed & tested by the community

I have reviewed the patch #2 and it is working fine and the error mentioned in description has been resolved.
There are some other errors but this has been covered in https://www.drupal.org/project/field_zip_file/issues/3298739
Moving to RTBC.

  • vhin0210 committed 05c754c on 1.x authored by Rakhi Soni
    Issue #3298740 by Rakhi Soni: Drupal calls should be avoided in classes...
vhin0210’s picture

vhin0210’s picture

Status: Reviewed & tested by the community » Fixed
sourabhjain’s picture

sourabhjain’s picture

Assigned: sourabhjain » Unassigned

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.