All dependencies must be prefixed with the project name

Hi,

I have reviewed patch #2, looks good to me. It applied cleanly and fixed all dependencies prefixed with the project name.

But still, there are some issues after running phpcs --standard=Drupalpractice -- that need to be fixed:

FILE: /Users/mrinalini.kumari/Documents/layoutcomponents/modules/lc_simple_text/lc_simple_text.module
-----------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------
 57 | WARNING | Unused variable $helper.
-----------------------------------------------------------------------------------------------------


FILE: /Users/mrinalini.kumari/Documents/layoutcomponents/modules/lc_commands/src/Commands/LcCommands.php
--------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
--------------------------------------------------------------------------------------------------------
 314 | WARNING | Unused variable $name.
 320 | WARNING | Unused variable $name.
--------------------------------------------------------------------------------------------------------


FILE: /Users/mrinalini.kumari/Documents/layoutcomponents/modules/lc_simple_view_carousel/lc_simple_view_carousel.module
-----------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------
 75 | WARNING | Unused variable $i.
-----------------------------------------------------------------------------------------------------------------------


FILE: /Users/mrinalini.kumari/Documents/layoutcomponents/modules/lc_simple_image/lc_simple_image.module
-------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------
 58 | WARNING | Unused variable $element.
-------------------------------------------------------------------------------------------------------


FILE: /Users/mrinalini.kumari/Documents/layoutcomponents/modules/lc_simple_title/lc_simple_title.module
-------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
-------------------------------------------------------------------------------------------------------
 57 | WARNING | Unused variable $helper.
 75 | WARNING | Unused variable $text.
-------------------------------------------------------------------------------------------------------


FILE: /Users/mrinalini.kumari/Documents/layoutcomponents/modules/sliderwidget/src/Element/Slider.php
------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------------------------
 460 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
------------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/mrinalini.kumari/Documents/layoutcomponents/src/Form/LcUpdateColumn.php
------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
------------------------------------------------------------------------------------
 120 | WARNING | Unused variable $key.
------------------------------------------------------------------------------------


FILE: /Users/mrinalini.kumari/Documents/layoutcomponents/src/Form/LcConfigureSection.php
----------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
----------------------------------------------------------------------------------------
 115 | WARNING | Unused variable $key.
 165 | WARNING | There must be no blank line following an inline comment
----------------------------------------------------------------------------------------


FILE: /Users/mrinalini.kumari/Documents/layoutcomponents/src/Plugin/Layout/LcBase.php
-------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-------------------------------------------------------------------------------------
 446 | WARNING | Unused variable $column_structures.
-------------------------------------------------------------------------------------


FILE: /Users/mrinalini.kumari/Documents/layoutcomponents/src/Plugin/Field/FieldWidget/LcFieldReferenceWidget.php
----------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 6 WARNINGS AFFECTING 6 LINES
----------------------------------------------------------------------------------------------------------------
 170 | WARNING | #options values usually have to run through t() for translation
 171 | WARNING | #options values usually have to run through t() for translation
 172 | WARNING | #options values usually have to run through t() for translation
 173 | WARNING | #options values usually have to run through t() for translation
 187 | WARNING | Unused variable $name.
 209 | WARNING | Unused variable $key.
----------------------------------------------------------------------------------------------------------------


FILE: /Users/mrinalini.kumari/Documents/layoutcomponents/src/Element/LcElement.php
----------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
----------------------------------------------------------------------------------
 197 | WARNING | Unused variable $delta.
 383 | WARNING | Variable $configure inside unset call is undefined.
 387 | WARNING | Variable $remove inside unset call is undefined.
----------------------------------------------------------------------------------


FILE: /Users/mrinalini.kumari/Documents/layoutcomponents/src/Controller/LcChooseSectionController.php
-----------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
-----------------------------------------------------------------------------------------------------
 173 | WARNING | Unused variable $key.
 175 | WARNING | Unused variable $classes.
 178 | WARNING | Unused variable $classes.
-----------------------------------------------------------------------------------------------------


FILE: /Users/mrinalini.kumari/Documents/layoutcomponents/src/Controller/LcChooseBlockController.php
---------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------
 150 | WARNING | Unused variable $lcSettings.
---------------------------------------------------------------------------------------------------


FILE: /Users/mrinalini.kumari/Documents/layoutcomponents/src/LcTheme.php
------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 5 WARNINGS AFFECTING 5 LINES
------------------------------------------------------------------------------------------------------------------------------------------
 182 | WARNING | Unused variable $delta.
 218 | WARNING | Unused variable $delta.
 252 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
 305 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 306 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
------------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/mrinalini.kumari/Documents/layoutcomponents/src/LcDisplayHelperTrait.php
-------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-------------------------------------------------------------------------------------
 113 | WARNING | Unused variable $delta.
-------------------------------------------------------------------------------------


FILE: /Users/mrinalini.kumari/Documents/layoutcomponents/src/LcLayoutRender.php
--------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 10 WARNINGS AFFECTING 10 LINES
--------------------------------------------------------------------------------------------------
 298 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
 445 | WARNING | Media::load calls should be avoided in classes, use dependency injection instead
 449 | WARNING | File::load calls should be avoided in classes, use dependency injection instead
 484 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
 565 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
 574 | WARNING | There must be no blank line following an inline comment
 589 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
 714 | WARNING | Media::load calls should be avoided in classes, use dependency injection instead
 718 | WARNING | File::load calls should be avoided in classes, use dependency injection instead
 946 | WARNING | Unused variable $description.
--------------------------------------------------------------------------------------------------


FILE: /Users/mrinalini.kumari/Documents/layoutcomponents/src/LcLayoutsManager.php
---------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
---------------------------------------------------------------------------------------------------------
 231 | WARNING | Unused variable $name.
 541 | WARNING | Role::loadMultiple calls should be avoided in classes, use dependency injection instead
 584 | WARNING | Unused variable $name.
---------------------------------------------------------------------------------------------------------

Thanks & Regards,
Mrinalini

Hi @rakhi, I reviewed your patch. It is working fine. @mrinalini9, I think this ticket is related to "All dependencies must be prefixed with the project name" not for the other Coding standard issues.

Lenovo@LAPTOP-PDE747K8 MINGW64 /c/xampp/htdocs/drupal-9/web/modules/contrib/layoutcomponents-3293015 (3293015-all-dependencies-must)
$ git apply -v all_dependencies_must_be_prefixed_with_project_name-3293015-2.patch
Checking patch modules/lc_simple_card_with_float_text/lc_simple_card_with_float_text.info.yml...
warning: modules/lc_simple_card_with_float_text/lc_simple_card_with_float_text.info.yml has type 100644, expected 100755
Checking patch modules/lc_simple_image_two_text_columns/lc_simple_image_two_text_columns.info.yml...
warning: modules/lc_simple_image_two_text_columns/lc_simple_image_two_text_columns.info.yml has type 100644, expected 100755
Checking patch modules/lc_simple_image_with_hover_text/lc_simple_image_with_hover_text.info.yml...
warning: modules/lc_simple_image_with_hover_text/lc_simple_image_with_hover_text.info.yml has type 100644, expected 100755
Checking patch modules/lc_simple_text_with_hover_image/lc_simple_text_with_hover_image.info.yml...
warning: modules/lc_simple_text_with_hover_image/lc_simple_text_with_hover_image.info.yml has type 100644, expected 100755
Applied patch modules/lc_simple_card_with_float_text/lc_simple_card_with_float_text.info.yml cleanly.
Applied patch modules/lc_simple_image_two_text_columns/lc_simple_image_two_text_columns.info.yml cleanly.
Applied patch modules/lc_simple_image_with_hover_text/lc_simple_image_with_hover_text.info.yml cleanly.
Applied patch modules/lc_simple_text_with_hover_image/lc_simple_text_with_hover_image.info.yml cleanly.

Thanks for the patch @rakhi. Moving it to RTBC.

Since patches are no longer tested, a merge request must be provided.

Created MR against #2