By submitting patches for review, you agree to the Developer Certificate of Origin. A copy of this agreement can be found in the project root, named CONTRIBUTING.txt.

Problem/Motivation

Crouton is using two internal APIs of Drupal's "system" module:

  • The system.site object's page.front configuration value (for duplicate "Home" link detection)
  • A breadcrumb testing trait, Drupal\Tests\system\Functional\Menu\AssertBreadcrumbTrait

Proposed resolution

Remove duplicate "Home" link detection with no planned replacement, and replace the dependency on Drupal's breadcrumb testing trait with our own breadcrumb testing trait.

CommentFileSizeAuthor
#5 3292968-4.patch16.02 KBclayfreeman
#3 3292968-3.patch15.85 KBclayfreeman

Comments

clayfreeman created an issue. See original summary.

clayfreeman’s picture

clayfreeman
he/him
Primary language English
commented
Title: Remove dependency on breadcrumb testing trait which is part of Drupal's internal API » Remove dependency on Drupal-internal front page configuration value and breadcrumb testing trait
Issue summary: View changes
clayfreeman’s picture

clayfreeman
he/him
Primary language English
commented
Status: Active » Needs review
StatusFileSize
new 3292968-3.patch15.85 KB

Status: Needs review » Needs work

The last submitted patch, 3: 3292968-3.patch, failed testing. View results

clayfreeman’s picture

clayfreeman
he/him
Primary language English
commented
Status: Needs work » Needs review
StatusFileSize
new 3292968-4.patch16.02 KB

  • clayfreeman committed b7837b5 on 1.0.x 
    Issue #3292968 by clayfreeman: Remove dependency on Drupal-internal...
clayfreeman’s picture

clayfreeman
he/him
Primary language English
commented
Assigned: clayfreeman » Unassigned
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.