Problem/Motivation

Found unused variable.

FILE: web\modules\contrib\group_domain\src\PathProcessor.php
---------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
---------------------------------------------------------------------------------------
58 | WARNING | Unused variable $alias_info.
222 | WARNING | Unused variable $group_base.
---------------------------------------------------------------------------------------

Time: 258ms; Memory: 8MB

CommentFileSizeAuthor
#8 PathProcessor.php—group_domain-noresults-alias_info.png680.26 KBroberttabigue
#8 PathProcessor.php—group_domain-noresults-group_base.png550.3 KBroberttabigue
#5 https:www.drupal:unused.png258.93 KBroberttabigue
#2 found-unused-variable-3291932-2.patch753 bytesashutosh ahirwal

Issue fork group_domain-3291932

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Ashutosh Ahirwal created an issue. See original summary.

ashutosh ahirwal’s picture

ashutosh ahirwal commented
Assigned: ashutosh ahirwal » Unassigned
StatusFileSize
new found-unused-variable-3291932-2.patch753 bytes

Providing patch.

mrinalini9’s picture

mrinalini9 commented

Hi,

I have reviewed patch #2, looks good to me. It applied cleanly and fixed all the above mentioned warnings.

Thanks & Regards,
Mrinalini

ashutosh ahirwal’s picture

ashutosh ahirwal commented

Hi, mrinalini9
If you have reviewed it and found no issue then change the status for RTBC.
Thanks

roberttabigue’s picture

roberttabigue commented
StatusFileSize
new https:www.drupal:unused.png258.93 KB

Hi Ash,

I'm new to this module and when I reviewed Patch #2, the unused variables have been removed.

Thank you.

roberttabigue’s picture

roberttabigue commented
Status: Needs review » Reviewed & tested by the community
roberttabigue’s picture

roberttabigue commented
roberttabigue’s picture

roberttabigue commented
StatusFileSize
new PathProcessor.php—group_domain-noresults-group_base.png550.3 KB
new PathProcessor.php—group_domain-noresults-alias_info.png680.26 KB

graber’s picture

graber commented
Status: Reviewed & tested by the community » Fixed

Thank you.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.