Problem/Motivation

When user click the update button or rebuild button, there is no confirmation block.

Steps to reproduce

Click the update button or rebuild button on the operations page.
URL: /admin/content/kb/MODEL_NAME/operations

Proposed resolution

It would be nice if module display a confirmation block before user submit on the update or rebuild button.

Issue fork quickchat-3281814

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

tanashin-kishimoto created an issue. See original summary.

tanashin-kishimoto’s picture

Issue summary: View changes
eleonel’s picture

Thanks Tanashin, I can see the following message after updating or rebuilding:

Success notification

Do you mean something else?

tanashin-kishimoto’s picture

Title: Add confirmation block and status messages when update and rebuild the model. » Add confirmation block when update or rebuild the model.
Issue summary: View changes
tanashin-kishimoto’s picture

@eleonel

My apologies, it was my mistake. The button does give feedback and a status message.
I have updated the issue's name and description for the confirmation block as a feature request.

Thank you

eleonel’s picture

Title: Add confirmation block when update or rebuild the model. » Improve message to user after execution update/rebuild actions

  • eleonel committed 09070f6 on 1.0.x
    Issue #3281814 by eleonel: Improve message to user after execution...
eleonel’s picture

Status: Active » Needs review

Hi Tanashin, I improved the feedback to users when we have some kind of error, please check.

tanashin-kishimoto’s picture

@eleonel

Add confirmation block when update or rebuild the model

AND

Improve message to user after execution update/rebuild actions

Is totally a different issue.
Could you please keep these issues for the confirmation block?

eleonel’s picture

Title: Improve message to user after execution update/rebuild actions » Add confirmation block when update or rebuild the model.
eleonel’s picture

Status: Needs review » Fixed
tanashin-kishimoto’s picture

Title: Add confirmation block when update or rebuild the model. » Add confirmation block when update or rebuild the model
eleonel’s picture

Hi Tanashin, please review the attached patch.

Rebuild checkbox

tanashin-kishimoto’s picture

@eleonel,

Thank you for your patch.
Patch work, I mark this issue as reviewed.

Although, we could improve the user experience by splitting the confirmation block to another page.

For example;
1. User click the update model button.
2. Drupal send to a confirmation page.
3. User click confirmation block.
4. Model update.

What do you think?

tanashin-kishimoto’s picture

Status: Needs review » Reviewed & tested by the community
eleonel’s picture

Status: Reviewed & tested by the community » Fixed

Awesome, I will merge the fix for now and take your idea from #14 for future UX improvements discussions.

  • eleonel committed 6b641fd on 1.0.x
    Issue #3281814 by eleonel: Add confirmation block when update or rebuild...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

eleonel’s picture

Status: Closed (fixed) » Needs review

naveenvalecha’s picture

Status: Needs review » Reviewed & tested by the community

PR looks good

  • eleonel committed ae313bb on 1.0.x
    Issue #3281814 by eleonel, tanashin-kishimoto, naveenvalecha: Add...
eleonel’s picture

Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.