Problem/Motivation

Getting notices:

  • Notice: Undefined index: field_c4c_css in Drupal\field_css\Traits\CssTrait::itemPrefixes() (line 36 of modules/contrib/field_css/src/Traits/CssTrait.php).
    Drupal\field_css\Traits\CssTrait::itemPrefixes(Object, 'default') (Line: 20)
field_css_entity_view_alter(Array, Object, Object) (Line: 539)
Drupal\Core\Extension\ModuleHandler->alter('commerce_store_view', Array, Object, Object) (Line: 305)
Drupal\Core\Entity\EntityViewBuilder->buildMultiple(Array) (Line: 239)
Drupal\Core\Entity\EntityViewBuilder->build(Array)
call_user_func_array(Array, Array) (Line: 101)
Drupal\Core\Render\Renderer->doTrustedCallback(Array, Array, 'Render #pre_render callbacks must be methods of a class that implements \Drupal\Core\Security\TrustedCallbackInterface or be an anonymous function. The callback was %s. See https://www.drupal.org/node/2966725', 'exception', 'Drupal\Core\Render\Element\RenderCallbackInterface') (Line: 772)
Drupal\Core\Render\Renderer->doCallback('#pre_render', Array, Array) (Line: 363)
Drupal\Core\Render\Renderer->doRender(Array, ) (Line: 201)
Drupal\Core\Render\Renderer->render(Array, ) (Line: 241)
Drupal\Core\Render\MainContent\HtmlRenderer->Drupal\Core\Render\MainContent\{closure}() (Line: 564)
Drupal\Core\Render\Renderer->executeInRenderContext(Object, Object) (Line: 242)
Drupal\Core\Render\MainContent\HtmlRenderer->prepare(Array, Object, Object) (Line: 132)
Drupal\Core\Render\MainContent\HtmlRenderer->renderResponse(Array, Object, Object) (Line: 90)
Drupal\Core\EventSubscriber\MainContentViewSubscriber->onViewRenderArray(Object, 'kernel.view', Object)
call_user_func(Array, Object, 'kernel.view', Object) (Line: 142)
Drupal\Component\EventDispatcher\ContainerAwareEventDispatcher->dispatch(Object, 'kernel.view') (Line: 163)
Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object, 1) (Line: 80)
Symfony\Component\HttpKernel\HttpKernel->handle(Object, 1, 1) (Line: 58)
Drupal\Core\StackMiddleware\Session->handle(Object, 1, 1) (Line: 48)
Drupal\Core\StackMiddleware\KernelPreHandle->handle(Object, 1, 1) (Line: 106)
Drupal\page_cache\StackMiddleware\PageCache->pass(Object, 1, 1) (Line: 85)
Drupal\page_cache\StackMiddleware\PageCache->handle(Object, 1, 1) (Line: 48)
Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle(Object, 1, 1) (Line: 51)
Drupal\Core\StackMiddleware\NegotiationMiddleware->handle(Object, 1, 1) (Line: 23)
Stack\StackedHttpKernel->handle(Object, 1, 1) (Line: 708)
Drupal\Core\DrupalKernel->handle(Object) (Line: 19)
require('/home/merlin/Code-Incubator/site-c4c-dev/web/index.php') (Line: 65)

  • Notice: Trying to access array offset on value of type null in Drupal\field_css\Traits\CssTrait::itemPrefixes() (line 36 of modules/contrib/field_css/src/Traits/CssTrait.php).
    Drupal\field_css\Traits\CssTrait::itemPrefixes(Object, 'default') (Line: 20)
field_css_entity_view_alter(Array, Object, Object) (Line: 539)
Drupal\Core\Extension\ModuleHandler->alter('commerce_store_view', Array, Object, Object) (Line: 305)
Drupal\Core\Entity\EntityViewBuilder->buildMultiple(Array) (Line: 239)
Drupal\Core\Entity\EntityViewBuilder->build(Array)
call_user_func_array(Array, Array) (Line: 101)
Drupal\Core\Render\Renderer->doTrustedCallback(Array, Array, 'Render #pre_render callbacks must be methods of a class that implements \Drupal\Core\Security\TrustedCallbackInterface or be an anonymous function. The callback was %s. See https://www.drupal.org/node/2966725', 'exception', 'Drupal\Core\Render\Element\RenderCallbackInterface') (Line: 772)
Drupal\Core\Render\Renderer->doCallback('#pre_render', Array, Array) (Line: 363)
Drupal\Core\Render\Renderer->doRender(Array, ) (Line: 201)
Drupal\Core\Render\Renderer->render(Array, ) (Line: 241)
Drupal\Core\Render\MainContent\HtmlRenderer->Drupal\Core\Render\MainContent\{closure}() (Line: 564)
Drupal\Core\Render\Renderer->executeInRenderContext(Object, Object) (Line: 242)
Drupal\Core\Render\MainContent\HtmlRenderer->prepare(Array, Object, Object) (Line: 132)
Drupal\Core\Render\MainContent\HtmlRenderer->renderResponse(Array, Object, Object) (Line: 90)
Drupal\Core\EventSubscriber\MainContentViewSubscriber->onViewRenderArray(Object, 'kernel.view', Object)
call_user_func(Array, Object, 'kernel.view', Object) (Line: 142)
Drupal\Component\EventDispatcher\ContainerAwareEventDispatcher->dispatch(Object, 'kernel.view') (Line: 163)
Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object, 1) (Line: 80)
Symfony\Component\HttpKernel\HttpKernel->handle(Object, 1, 1) (Line: 58)
Drupal\Core\StackMiddleware\Session->handle(Object, 1, 1) (Line: 48)
Drupal\Core\StackMiddleware\KernelPreHandle->handle(Object, 1, 1) (Line: 106)
Drupal\page_cache\StackMiddleware\PageCache->pass(Object, 1, 1) (Line: 85)
Drupal\page_cache\StackMiddleware\PageCache->handle(Object, 1, 1) (Line: 48)
Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle(Object, 1, 1) (Line: 51)
Drupal\Core\StackMiddleware\NegotiationMiddleware->handle(Object, 1, 1) (Line: 23)
Stack\StackedHttpKernel->handle(Object, 1, 1) (Line: 708)
Drupal\Core\DrupalKernel->handle(Object) (Line: 19)
require('/home/merlin/Code-Incubator/site-c4c-dev/web/index.php') (Line: 65)

    • Steps to reproduce

    View a display mode that does not display the css field.

    Proposed resolution

    Add some "if".

    CommentFileSizeAuthor
    #6 3280478-6.patch1.38 KBcarlxjs
    #2 field_css-adds-additional-validation-3280478-2.patch1.33 KB_shy

    Comments

    geek-merlin created an issue. See original summary.

    _shy’s picture

    _shy
    Primary language Ukrainian
    Location Ukraine, Lutsk 🇺🇦
    commented
    Status: Active » Needs review
    StatusFileSize
    new field_css-adds-additional-validation-3280478-2.patch1.33 KB

    Hi!
    Here is a patch that should solve an issue. Added additional validation to avoid such type of notices.

    geek-merlin’s picture

    geek-merlin
    Primary language German
    Location Freiburg, Germany
    commented
    Issue summary: View changes
    Status: Needs review » Reviewed & tested by the community

    Thanks for quickly rolling the patch!

    Code-wise it's like i thought.
    Nit: Code may get much more readable using the ?? operator.
    Tested it, and it fixes the issue.

    chris burge’s picture

    chris burge commented
    Related issues: +#3212501: Warning on rendering Media-Entity with field_css as thumbail

    Crosslinking to #3212501: Warning on rendering Media-Entity with field_css as thumbail.

    chris burge’s picture

    chris burge commented
    Status: Reviewed & tested by the community » Needs work
    carlxjs’s picture

    carlxjs commented
    StatusFileSize
    new 3280478-6.patch1.38 KB

    The patch file in #2 can not apply in 2.0.x-dev now.
    So I make a new patch for 2.0.x-dev.

    roberto_araya’s picture

    roberto_araya commented

    The patch in #6 work to me, on Drupal 9.4.11 and on 2.x-dev. Thanks!

    geek-merlin’s picture

    geek-merlin
    Primary language German
    Location Freiburg, Germany
    commented
    Status: Needs work » Reviewed & tested by the community

    So rtbc. If someone makes a MR, i'll commit it soon-ish.

    • geek-merlin committed 6e0fea8a on 2.0.x 
      Issue #3280478 by carlxjs, _shY, geek-merlin, Chris Burge, roberto_araya...
    geek-merlin’s picture

    geek-merlin
    Primary language German
    Location Freiburg, Germany
    commented
    Status: Reviewed & tested by the community » Fixed

    Committed. Thank ya all!

    geek-merlin’s picture

    geek-merlin
    Primary language German
    Location Freiburg, Germany
    commented

    Rolling a new RC release, which might become 1.0.0 after some weeks with no problems.

    Status: Fixed » Closed (fixed)

    Automatically closed - issue fixed for 2 weeks with no activity.