We need to determine the number of items in a list.
For counting, we could implement an action that counts items on a specified Token and sets the count result into another token. For convenience, we could additionally implement a condition "number of items" extending from StringComparisonBase. That count action would only address "real" lists as we already have "Compare two scalar values" that may directly count a string length.
| Comment | File | Size | Author |
|---|---|---|---|
| #11 | Screenshot 2022-05-17 at 18.14.34.png | 43.82 KB | mxh |
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #2
jurgenhaasComment #4
jurgenhaasIf the structure is OK this way, I'll add more tests.
Comment #5
mxh commentedThe only thing that should be considered is the check for \Traversable and calling iterator_count on such an object. The other notes are just minor ones.
Comment #6
jurgenhaasCovered your comments and tests included.
Comment #7
mxh commentedOnly minor comments, otherwise good to go. Big 👍🏼 for the great tests!
Comment #8
jurgenhaasSetting back for another review, names have changed a bit more than maybe expected.
Comment #9
mxh commentedSorry need to set once more to NW due the found problem with plugins having the same ID. Otherwise looks good and can be merged.
Comment #10
jurgenhaasHad to take a different approach as we have no control over plugin ids across different plugin managers. Updated the bpmn id instead by including the plugin type into the id.
Comment #11
mxh commentedTook a second look and noticed that some settings on the condition plugin don't make sense to be shown via UI. Attached a screenshot with the affected ones that could be hidden IMO. Otherwise good to go.
Comment #13
jurgenhaasThat's correct - as it is a broader issue, I moved that into #3280939: Add support for hidden config form fields and as it doesn't hurt here, merged and closed this issue.