https://www.drupal.org/pift-ci-job/2374991
1) Drupal\Tests\facets_form_date_range\Functional\DateRangeIntegrationTest::testDateRangeDateOnly
Behat\Mink\Exception\ExpectationException: Current page is "/test?f%5B0%5D=authored_on%3A2021-08-16~", but "/test?f[0]=authored_on%3A2021-08-16~" expected.
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | facets_form-1.x-3280015-3-FacetUrlTestTrait.patch | 7.04 KB | donquixote |
| #3 | facets_form-1.x-3280015-3-FacetUrlTestTrait.interdiff.txt | 2.09 KB | donquixote |
Issue fork facets_form-3280015
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
donquixote commentedComment #3
donquixote commentedCode style fix.
Comment #6
donquixote commentedThe tests in facets module all use
Url::fromUserInput()to test facet urls.So I am doing the same here, but with a helper method for convenience.
One thing I am not sure about is IntegrationTest::assertCurrentUrl().
For some reason there is no complaining about url-encoded square brackets here.
Also the part after
$this->assertSession()->addressEquals($expected_url);seems weird: If query parts are in different order, wouldn't this already cause the previous assertion to fail?Comment #7
donquixote commentedSo the actual problem was this: #3164686: WebAssert::addressEquals() and AssertLegacyTrait::assertUrl() fail to check the querystring
With Drupal 9.2.*, the tests would pass because the query string was ignored in the assertions.
With Drupal 9.3.*, the tests fail because of urlencode, and because some of them actually had wrong expectations.
Comment #8
donquixote commentedComment #11
andras_szilagyi commentedmerged, thx