When performing a fresh install of Drupal, the main heading states "Welcome to < site name >" where the site name can be anything from "Bobs Burgers" to "Drush Site Install". This seems kind of clunky and awkward to me, because the text below talks about Drupal (as opposed to the site).

I propose to change it to simply "Welcome!"

CommentFileSizeAuthor
#25 Welcome____💩.png174.39 KBmherchel
#20 olivero-theme-change-welcome-text-on-the-initial-install-screen-3279703-20.png316.8 KBmaninders
#20 olivero-theme-change-welcome-text-on-the-initial-install-screen-3279703-20.patch1.66 KBmaninders
#11 after.png69.54 KBlibbna
#11 before.png70.43 KBlibbna
#9 3279703-9.patch1.82 KBbinoli lalani
proposed.png159.42 KBmherchel
current.png160.42 KBmherchel

Issue fork drupal-3279703

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

mherchel created an issue. See original summary.

ckrina’s picture

ckrina
she/her
Primary language Catalan
Location Barcelona
commented

+1 to this simplification.

mherchel’s picture

mherchel
he/him
Primary language English
Location Gainesville, FL, US
commented
Issue summary: View changes
longwave’s picture

longwave
he/him
Primary language English
Location UK
commented

This is a nice simplification but I wonder if we should remove the other exclamation mark on the "Congratulations" line if we are adding one here, it looks a bit shouty with one on both lines.

mherchel’s picture

mherchel
he/him
Primary language English
Location Gainesville, FL, US
commented

Makes sense to me. I'm going to bring it to the UX meeting on Friday #3279239: Drupal Usability Meeting 2022-05-13

Binoli Lalani made their first commit to this issue’s fork.

Binoli Lalani opened merge request !2265

binoli lalani’s picture

binoli lalani commented
Assigned: Unassigned » binoli lalani
binoli lalani’s picture

binoli lalani commented
StatusFileSize
new 3279703-9.patch1.82 KB
binoli lalani’s picture

binoli lalani commented
Assigned: binoli lalani » Unassigned
Status: Active » Needs review

Hello,

I have changed "Welcome to " to "Welcome!" and removed exclamation mark from "Congratulations" line.

Have created a MR and attached the patch as well. Please review and let me know if require any changes.

Thanks

libbna’s picture

libbna commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new before.png70.43 KB
new after.png69.54 KB

I have reviewed and it LGTM. Added screenshots.

mherchel’s picture

mherchel
he/him
Primary language English
Location Gainesville, FL, US
commented
Status: Reviewed & tested by the community » Needs work

Nightwatch tests are failing (maybe we check for that text?)

Also, can we add a period after "Congratulations and welcome to the Drupal community" ?

Also, we're taking this to the UX meeting tomorrow, so there may be more changes.

mherchel’s picture

mherchel
he/him
Primary language English
Location Gainesville, FL, US
commented
Issue summary: View changes
mherchel’s picture

mherchel
he/him
Primary language English
Location Gainesville, FL, US
commented
Issue summary: View changes
mherchel’s picture

mherchel
he/him
Primary language English
Location Gainesville, FL, US
commented
Issue summary: View changes

I brought this to the Drupal UX meeting at #3279239: Drupal Usability Meeting 2022-05-13. There was unanimous consensus to making the the heading say "Welcome!", and swapping out the exclamation point with a period for the "Congratulations and welcome to the Drupal community" text.

stockfoot’s picture

stockfoot commented
Assigned: Unassigned » stockfoot
Issue summary: View changes

New contributor here, I am going to try and tackle this!
Assigning this to myself to begin making the change.

Stockfoot opened merge request !2272

stockfoot’s picture

stockfoot commented
Assigned: stockfoot » Unassigned
Status: Needs work » Needs review

The changes have been made and the merge request has been set up.
It can be viewed here - https://git.drupalcode.org/project/drupal/-/merge_requests/2272

Hopefully, I did everything correctly. Let me know if any changes are needed or if I messed up in the process of any of this, thank you!

Unassigning myself and setting status to "Needs Review"

mherchel’s picture

mherchel
he/him
Primary language English
Location Gainesville, FL, US
commented
Status: Needs review » Needs work

Left some feedback. We also need to fix the tests that check for this text.

maninders’s picture

maninders commented
Status: Needs work » Needs review
StatusFileSize
new olivero-theme-change-welcome-text-on-the-initial-install-screen-3279703-20.patch1.66 KB
new olivero-theme-change-welcome-text-on-the-initial-install-screen-3279703-20.png316.8 KB

Hi

Created a patch for Change "Welcome to " to "Welcome!" on the initial install screen, And also added a patch for "Congratulations and welcome to the Drupal community!" to "Congratulations and welcome to the Drupal community".

Status: Needs review » Needs work

The last submitted patch, 20: olivero-theme-change-welcome-text-on-the-initial-install-screen-3279703-20.patch, failed testing. View results

Ruturaj Chaubey made their first commit to this issue’s fork.

ruturaj chaubey’s picture

ruturaj chaubey
He/Him
Primary language English
Location Pune, India
commented
Status: Needs work » Needs review

Added the requested changes to an existing MR.
MR link - https://git.drupalcode.org/project/drupal/-/merge_requests/2272
Thank you.

VIGHNESH SADAGOPAL made their first commit to this issue’s fork.

mherchel’s picture

mherchel
he/him
Primary language English
Location Gainesville, FL, US
commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new Welcome____💩.png174.39 KB

Changes from the most recent MR look perfect! The tests are green and I manually tested this out. Thank you @vighnesh-sadagopal!

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Issue tags: +Needs product manager review

Since this is a significant user facing change, I think it would be good to have a sign-off from the product managers on this.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Issue tags: -Needs product manager review

I think this looks fine. Less "Welcome to drush site-install" :D I agree depending on the site name used, there could be awkard combinations.

mherchel’s picture

mherchel
he/him
Primary language English
Location Gainesville, FL, US
commented

Change record at https://www.drupal.org/node/3282096

  • lauriii committed 41761dc on 10.0.x 
    Issue #3279703 by VIGHNESH SADAGOPAL, Binoli Lalani, Stockfoot,...

  • lauriii committed 7ecb8bd on 9.5.x 
    Issue #3279703 by VIGHNESH SADAGOPAL, Binoli Lalani, Stockfoot,...

  • lauriii committed 0d206cf on 9.4.x 
    Issue #3279703 by VIGHNESH SADAGOPAL, Binoli Lalani, Stockfoot,...
lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Version: 9.5.x-dev » 9.4.x-dev
Status: Reviewed & tested by the community » Fixed

Committed 41761dc and pushed to 10.0.x. Also cherry-picked to 9.5.x and 9.4.x. Thanks!

lauriii closed merge request !2272

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.