Problem/Motivation

Currently there are two blocks in core/themes/olivero/config/optional that _don't_ contain the theme-name (so Olivero) in their name:

block.block.book_navigation.yml 
block.block.primary_admin_actions.yml

This is really out of tune with all other theme blocks.

Proposed resolution

Rename those two blocks:

block.block.book_navigation.yml => block.block.olivero_book_navigation.yml 
block.block.primary_admin_actions.yml => block.block.olivero_primary_admin_actions.yml

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#3 3278696-3.patch2.63 KBSpokje
#3 interdiff_2-3.txt1.03 KBSpokje
#2 3278696-2.patch1.42 KBSpokje
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Spokje created an issue. See original summary.

Spokje’s picture

Spokje
Primary language Dutch
CreditAttribution: Spokje as a volunteer commented
FileSize
3278696-2.patch1.42 KB
Spokje’s picture

Spokje
Primary language Dutch
CreditAttribution: Spokje as a volunteer commented
FileSize
interdiff_2-3.txt1.03 KB
3278696-3.patch2.63 KB
lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
CreditAttribution: lauriii at Acquia commented
Status: Active » Reviewed & tested by the community

Totally makes sense for me! Not sure why these block configurations were named like this in the first place but I couldn't imagine there would be a particular reason to do so.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Acro Commerce, Thunder commented
Version: 10.0.x-dev » 9.4.x-dev
Status: Reviewed & tested by the community » Fixed

Committed and pushed d8b72b6a4d to 10.0.x and 07230e83ce to 9.5.x and 667130beb8 to 9.4.x. Thanks!

  • alexpott committed d8b72b6 on 10.0.x 
    Issue #3278696 by Spokje: Rename Oliveros block.block.book_navigation....

  • alexpott committed 07230e8 on 9.5.x 
    Issue #3278696 by Spokje: Rename Oliveros block.block.book_navigation....

  • alexpott committed 667130b on 9.4.x 
    Issue #3278696 by Spokje: Rename Oliveros block.block.book_navigation....
Spokje’s picture

Spokje
Primary language Dutch
CreditAttribution: Spokje as a volunteer commented
Assigned: Spokje » Unassigned

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.