Problem/Motivation

Several class properties can actually be null but do not declare in their docbloc which creates false positives during phpstan runs.
At least one (in tests) should use an interface.

Steps to reproduce

Review Code

Proposed resolution

Update property definitions.

Remaining tasks

Patch

User interface changes

None

API changes

Changes as written, however no functional changes.

Data model changes

None

Issue fork rabbitmq-3278100

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

cmlara created an issue. See original summary.

cmlara opened merge request !23

cmlara’s picture

cmlara
he/him
commented
Assigned: cmlara » Unassigned
Status: Active » Needs review
gaards’s picture

gaards commented
Status: Needs review » Reviewed & tested by the community

Looks good, RTBC

cmlara’s picture

cmlara
he/him
commented
Status: Reviewed & tested by the community » Fixed

Thanks for the review.

Merged (with trivial rebase) into dev.

And I believe this is the last bit of code that I wanted to work on that could of resulted in a change of API. I think I am just about ready to tag a 3.0.0-beta release.

  • cmlara committed 9f26287 on 3.x 
    Issue #3278100 by cmlara, gaards: Update class property definitions

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.