Problem/Motivation

Split from #3219959: Update standard profile so Olivero is the default theme.

Olivero adds Javascript for anonymous users, so the test will fail, but we still want to have the test in core.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#10 3276620-10.patch2.48 KBspokje
#10 interdiff_7-10.txt1.86 KBspokje
#7 3276620-7.patch1.42 KBcatch
#7 3276620-interdiff.txt561 bytescatch
#5 3276620-4.patch1.38 KBcatch
#5 3276620-interdiff.txt561 bytescatch
#3 3276620.patch1.37 KBcatch
#2 3276620.patch1.31 KBcatch

Comments

catch created an issue. See original summary.

catch’s picture

catch
he/him
Primary language English
commented
Status: Active » Needs review
StatusFileSize
new 3276620.patch1.31 KB

Maybe something like this.

catch’s picture

catch
he/him
Primary language English
commented
StatusFileSize
new 3276620.patch1.37 KB

Ooof, without the tabs, something up with paste.

Status: Needs review » Needs work

The last submitted patch, 3: 3276620.patch, failed testing. View results

catch’s picture

catch
he/him
Primary language English
commented
Status: Needs work » Needs review
StatusFileSize
new 3276620-interdiff.txt561 bytes
new 3276620-4.patch1.38 KB

grr.

Status: Needs review » Needs work

The last submitted patch, 5: 3276620-4.patch, failed testing. View results

catch’s picture

catch
he/him
Primary language English
commented
Status: Needs work » Needs review
StatusFileSize
new 3276620-interdiff.txt561 bytes
new 3276620-7.patch1.42 KB

Status: Needs review » Needs work

The last submitted patch, 7: 3276620-7.patch, failed testing. View results

catch’s picture

catch
he/him
Primary language English
commented

This isn't as simple as just installing the modules, because it's relying on the default configuration in the standard profile.

spokje’s picture

spokje
Primary language Dutch
commented
Status: Needs work » Needs review
StatusFileSize
new interdiff_7-10.txt1.86 KB
new 3276620-10.patch2.48 KB

This isn't as simple as just installing the modules, because it's relying on the default configuration in the standard profile.

Well, "let's just fake that shit!"...

catch’s picture

catch
he/him
Primary language English
commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +Needs follow-up

That's better, thanks for finishing the job.

Last question for me - do we want to switch from the hard-coded list of modules to enabling everything (non-experimental and non-deprecated) under the sun - but that decision shouldn't block Olivero becoming the default theme, so follow-up material.

  • a9119bc committed on 10.0.x 
    Issue #3276620 by catch, Spokje: Change NoJavaScriptAnonymousTest to use...

  • 02693ce committed on 9.4.x 
    Issue #3276620 by catch, Spokje: Change NoJavaScriptAnonymousTest to use...
gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Reviewed & tested by the community » Fixed

Looks good IMHO, committed. The followup still needs to be opened.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Issue tags: +Portland2022

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

quietone’s picture

quietone commented
Issue tags: -Needs follow-up

Checking issues with 'needs followup'

The follow-up is #3306712: Update NoJavaScriptAnonymousTest to use Standard profile instead of listing modules, therefor I am removing the tag.