Recently had a client with an older site who wants to update and add some features. While my team is working on the rest of the system update I was attempting to add some of the requested features, including basically this module's functions. The info.yml file indicates this module is compatilbe with 8.8 and above, but also requires commerce_shipping 2.3 in the composer file, which requires drupal core 9.2 at minimum. Is there a reason this couldn't require commerce_shipping 2.2 or above?

Issue fork commerce_shipping_boxpacker-3274932

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

drakythe created an issue. See original summary.

drakythe’s picture

drakythe commented
Issue summary: View changes

Edited to specify where the mixed requirement comes from.

zengenuity’s picture

zengenuity commented

I'm not sure. I think I must have added that because that's the version of commerce_shipping we were running when I wrote the module. I don't know of any specific reason it must be that version though.

If you test it with 2.2 and it works fine, report back and we can update the requirement in the info file.

drakythe’s picture

drakythe commented

Tested and verified the module works just fine with commerce_shipping-2.2, which allows Drupal 8.9.x sites to run this.

drakythe opened merge request !1

zengenuity’s picture

zengenuity commented
Status: Active » Fixed

Merged this change. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.