Problem/Motivation

Update to CKEditor 5 v34.0.0 in core: https://github.com/ckeditor/ckeditor5/releases/tag/v34.0.0.

Proposed resolution

  1. core/package.json
  2. cd core
  3. yarn install
  4. yarn run vendor-update
  5. yarn run build:ckeditor5
  6. yarn run build:ckeditor5-types

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

The CKEditor 5 module now uses version 34.0.0 of the CKEditor 5 JavaScript library, which fixes several critical issues.

CommentFileSizeAuthor
#6 core-cke-v34-3274767-9.3.x.patch2.52 MBnod_
#6 core-cke-v34-3274767-10.x.patch2.33 MBnod_
#2 core-cke-v34-3274767.patch2.33 MBnod_
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

nod_ created an issue. See original summary.

nod_’s picture

nod_
Primary language French
Location Lille
CreditAttribution: nod_ commented
FileSize
core-cke-v34-3274767.patch2.33 MB
nod_’s picture

nod_
Primary language French
Location Lille
CreditAttribution: nod_ commented
Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, 2: core-cke-v34-3274767.patch, failed testing. View results

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm at Acquia commented
Version: 9.4.x-dev » 9.3.x-dev

https://www.drupal.org/pift-ci-job/2359129 is a known random; requeuing.

We also need 10.0.x and 9.3.x patches.

nod_’s picture

nod_
Primary language French
Location Lille
CreditAttribution: nod_ commented
FileSize
core-cke-v34-3274767-10.x.patch2.33 MB
core-cke-v34-3274767-9.3.x.patch2.52 MB

10.x and 9.3 patch

nod_’s picture

nod_
Primary language French
Location Lille
CreditAttribution: nod_ commented
Status: Needs work » Needs review
lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
CreditAttribution: lauriii at Acquia commented
Status: Needs review » Reviewed & tested by the community

I reviewed the drupalImage changes manually and it seems like they are related to changes in a GHS conversion helper we are using.

I did some manual testing to confirm that there aren't any immediately apparent regressions.

Confirmed locally that all patches (10.0.x, 9.4.x and 9.3.x) have been generated correctly.

  • catch committed 5e70a26 on 10.0.x 
    Issue #3274767 by nod_, lauriii: Update to CKEditor 5 v34.0.0

  • catch committed f093c32 on 9.4.x 
    Issue #3274767 by nod_, lauriii: Update to CKEditor 5 v34.0.0

  • catch committed 02e09e2 on 9.3.x 
    Issue #3274767 by nod_, lauriii: Update to CKEditor 5 v34.0.0
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed the respective patches to 10.0.x, 9.4.x and 9.3.x, thanks!

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm at Acquia commented
Issue tags: +10.0.0 release notes, +9.3.10 release notes
xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm at Acquia commented
Issue summary: View changes
Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers at Acquia commented
Related issues: +#3268318: [drupalMedia] <a> with GHS allowed attributes downcast wraps data-caption with <a>, +#3268311: [upstream] [drupalMedia] GHS-enabled markup in data-caption crashes CKEditor 5

Looks like this went wonderfully smooth! 👏

This also unblocked #3268318: [drupalMedia] <a> with GHS allowed attributes downcast wraps data-caption with <a> and #3268311: [upstream] [drupalMedia] GHS-enabled markup in data-caption crashes CKEditor 5.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.