Problem/Motivation
While working on a system for a client, we introduced views bulk operations into the table. This made it difficult at times to check the checkbox on each row without triggering the expansion/collapsing. This patch introduces a table settings (style options) checkbox to disable (enabled by default) the clickable row, and instead appends a span to the end of the last visible column to expand/collapse the table.
Steps to reproduce
This issue is most identifiable with views bulk operations, so install this module with views bulk operations and get a view setup with some content to use both. The checkboxes for VBO can be difficult to target/click without triggering the table row expansion.
Proposed resolution
Add in a 'settings' configuration option to use a triggering element (instead of the default triggering row) to trigger the expand/collapse.
When not using the entire table row, append a new span to the end of the last visible column and attach the trigger class to it for clicking.
User interface changes
There is now an additional 'table settings' option when using the views expandable table views style that is checked by default. The default setting is to use the table row as the trigger.
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | views_expandable_table_configuration.png | 69.25 KB | jfurnas |
Issue fork views_expandable_table-3274298
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
jfurnas commentedComment #4
jfurnas commentedComment #5
jfurnas commentedComment #6
jfurnas commentedComment #7
jfurnas commentedComment #8
christian le fournis commentedLooks like a great addition to the module, can we merge to Dev?
Comment #10
kerasai commentedHi there,
I've done a cursory review, and this seems mostly fine.
The one thing I've noticed, is that you've added the
LICENSE.txtand changes to the module's.info.ymlfile. These are added to the Composer package/download automatically by Drupal's package handling system and shouldn't be included in the module's repo.Otherwise, it's probably good to merge.
Thanks!
Comment #11
kerasai commentedComment #13
jfurnas commentedAll set. The licensing and *.info.yml information has been removed.
Comment #14
jfurnas commented