Problem/Motivation
When switching the media library core bulk actions field to VBO + views_bulk_edit, which provides bulk editing and a lot more functionality, the styling of the checkbox is broken in the media library.
We should instead handle the VBO views checkbox 1:1 like the core one so both work. We definitely need VBO in large projects media library to be able to bulk edit media entity field values.
An example for the bug is "GS" ;)
Steps to reproduce
Proposed resolution
Style VBO checkboxes like core bulk actions
Try to replace core bulk actions form by VBO for the following benefits:
- Select all - functionality
- Modify values functionality
Remaining tasks
User interface changes
API changes
Data model changes
Issue fork drowl_media-3274230
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
anybody@thomas.frobieter please look at this in the context of "GS" (but after all other changes and a new stable release!)
Comment #3
anybody@thomas.frobieter: In 3.1.0 (and our VL) is prepared the switch to VBO in general. Currently the field is still hidden, but was already added. We should have a look at this. You can already prepare the styling of course.
But then we should check, if there are any drawbacks from this replacement.
Comment #4
anybody@thomas.frobieter I just tried VBO at MD, but if I check checkboxes, even by "select all" it always says "No entries selected". No idea why, but for that reason I'll remove VBO until we can have a look.
Comment #6
anybodyComment #7
anybody@thomas.frobieter after testing it carefully, we might also completely replace the core bulk actions by VBO. Call me when you're ready, as this is important for larger pages from time to time so higher priority, but not critical.
We should solve this early once you have the time.
Comment #8
anybodyOkay, indeed core AND VBO can't Co-Exist (not even hidden) in the same view, VBO has to replace the core select, otherwise both say "Nothing selected".
Styling should be compatible with both for special cases and backwards compatibility. When styling is in here, I'll create an update hook for the views.media_library.yml changes.
Old core style can be tested in VL, new VBO checkbox at GS.
Comment #9
anybodyComment #10
thomas.frobieterHopefully VBO is not that buggy as it seems in the GS project. I will try to add the VBO styles as addition to the regular media library styles, so we can disable VBO at all time.
Update: Just saw that the regular media library checkboxes are still present in the media selection widgets, so we MUST support both at the same time.
Comment #12
thomas.frobieterComment #13
anybodyReview done, just some final adjustments, then this is ready to go! (resolve the reviews)
Do you see any risk of breaking pages where VBO is NOT used? I think not... but please finally think about that.
Comment #14
thomas.frobieterNo, I wrote it explicitly to support both. No changes to the core bulk styles, only additions for VBO.
Comment #15
anybodyAll fine!
Comment #16
anybody