Problem/Motivation

Running compose require drupal/devel_php on a php7.3(or less) environment, installs the latest version which is not compatible with it.

Steps to reproduce

Running compose require drupal/devel_php on a php7.3 environment.

Proposed resolution

Adds "php": ">=7.4" requirement in the composer.json

Issue fork devel_php-3274188

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Damien LAGUERRE created an issue. See original summary.

Damien LAGUERRE opened merge request !5

damien laguerre’s picture

damien laguerre commented
Status: Active » Needs review
grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Issue tags: +ddd2022

Hello,

My bad, thanks for the catch.

I had the same problem in the Matomo module too.

And as Drupal 9 core is still supporting PHP 7.3, the solution should be to remove type in properties.

In this case, I will see if at this moment I should create a new branch for D10 and PHP 8.1 or waiting for D9 to not be supported.

grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Assigned: Unassigned » grimreaper

Grimreaper opened merge request !6

damien laguerre’s picture

damien laguerre commented

Hello,

I suggested adding this requirement in composer.yml because the requirement is already in the .info.yml.

But yes, the best solution might be to remove the types.

grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Assigned: grimreaper » Unassigned

Thanks for the info, then it means that composer.json overrides php version requirement from .info.yml.

OK, I forgot that I put the requirement in .info.yml so it means that I thought about it :p

Hum, If I didn't published 8.x-1.4 we could have stayed with the requirement of PHP >= 7.4 because Devel PHP is quite stable and it is only some code quality changes, so people would have stayed on 8.x-1.3, but the problem is that people will end up with 8.x-1.4 version.

So I have to make a new one.

grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented

Can you give a try to https://git.drupalcode.org/project/devel_php/-/merge_requests/6 please?

damien laguerre’s picture

damien laguerre commented

Tested!
There are no more errors, everything works fine in PHP7.3.

Thanks for your speed ;-)

  • Grimreaper committed 1698ca0 on 8.x-1.x 
    Issue #3274188 by Damien LAGUERRE, Grimreaper: Typed properties are only...

Grimreaper closed merge request !5

grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Status: Needs review » Fixed

Thanks!

And thanks for the quick bug report too!

New release done: https://www.drupal.org/project/devel_php/releases/8.x-1.5

grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented

Hum, I forgot to remove PHP 7.4 in .info.yml.

Doing too many stuff in parallel, sorry.

I will keep it as it is for now and remove in a new issue if someone needs the change.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.