Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.By submitting patches for review, you agree to the Developer Certificate of Origin. A copy of this agreement can be found in the project root, named CONTRIBUTING.txt.
Problem/Motivation
It's currently rather difficult to debug when a user encounters restriction enforcement. We should add logging to help this process.
Proposed resolution
Add a configuration option, "Enable logging," which will record a log message after enforcement when checked.
User interface changes
A new configuration option will be added in Geoblock's settings.
API changes
The logger channel factory service will need to be injected into the request event subscriber. Since we don't yet have a stable release, we do not need to be concerned with breaking backward compatibility.
Data model changes
The settings object for Geoblock will have a new boolean key, enable_logging.
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | 3273550-5-interdiff.txt | 465 bytes | clayfreeman |
| #5 | 3273550-5.patch | 5.84 KB | clayfreeman |
Comments
Comment #2
clayfreemanComment #3
clayfreemanComment #4
clayfreemanEnsure that a blank country code produces "unknown" instead of an empty value in the logged message.
Comment #5
clayfreemanFix argument order for logging method.
Comment #7
clayfreeman