Problem/Motivation

Steps to reproduce

Deprecate the existing library and create a new core/internal.underscore library to provide underscore for internal.backbone until the usages are removed.

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

The underscore JS library has been deprecated in Drupal 9.4.0. There is no replacement.

Issue fork drupal-3272872

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

nod_ created an issue. See original summary.

nod_ opened merge request !2038

nod_’s picture

nod_
Primary language French
Location Lille
commented
Status: Active » Needs review
thiagoht’s picture

thiagoht commented
Assigned: Unassigned » thiagoht

I'll check it out!

thiagoht’s picture

thiagoht commented
Assigned: thiagoht » Unassigned
Status: Needs review » Reviewed & tested by the community

Looks like everything ok!

  1. 1: I searched for any file that use core/underscore as a dependency and seems that all was covered by @node_
  2. 2: I checked it out the changes on core/modules/editor/editor.libraries.yml - OK
  3. 3: I checked it out the changes on core/modules/filter/filter.libraries.yml - OK
  4. 4: I checked it out the changes on core/modules/image/image.libraries.yml - OK
  5. 5: I checked it out the changes on core/modules/quickedit/quickedit.libraries.yml - OK
  6. 6: The library was added as internal.underscore in core/scripts/js/vendor-update.js
  7. 7: I checked it out if the deprecated message is showing: core/core.libraries.yml
murilohp’s picture

murilohp commented

Just added a CR here about underscore being deprecated and how to replace it using vanilla js.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Issue summary: View changes
Status: Reviewed & tested by the community » Fixed

Committed 49a6133 and pushed to 10.0.x. Thanks!
Committed 7be4a4f and pushed to 9.4.x. Thanks!

I applied the patch on to 10.0.x using a 3 way merge and resolved the conflicts.

@murilohp thanks for writing the CR I've credited you on this issue for that.
@thiagoht thanks for the review detailing what you did.

  • alexpott committed 49a6133 on 10.0.x 
    Issue #3272872 by nod_: deprecate underscore and mark it internal

  • alexpott committed 7be4a4f on 9.4.x 
    Issue #3272872 by nod_: deprecate underscore and mark it internal
xjm’s picture

xjm
she/her
Primary language English
commented
Issue tags: +9.4.0 release notes, +10.0.0 release notes

xjm closed merge request !2038

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.