Problem/Motivation

This is part of #3267247: [meta] Fix and re-enable tests skipped for random failures, for LayoutBuilderTest::testConfigurableLayoutSections().

See the parent issue for steps to reproduce/proposed resolution.

CommentFileSizeAuthor
#11 lb-3272797-11-fix-only.patch4.15 KBxjm
#9 3272797-9-1000x.patch5.89 KBbnjmnm
#9 interdiff_8-9.txt3.41 KBbnjmnm
#8 3272797-8-1000x.patch5.65 KBbnjmnm
#5 3272797-5-1000x.patch3.89 KBphenaproxima
#3 3272797-3-FAIL-1000x.patch2.65 KBphenaproxima

Comments

phenaproxima created an issue. See original summary.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Issue tags: +Random test failure
phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Status: Active » Needs review
StatusFileSize
new 3272797-3-FAIL-1000x.patch2.65 KB

Standard procedure, let's start with a patch that un-skips the offending test and runs it 1,000 times.

Status: Needs review » Needs work

The last submitted patch, 3: 3272797-3-FAIL-1000x.patch, failed testing. View results

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Status: Needs work » Needs review
StatusFileSize
new 3272797-5-1000x.patch3.89 KB

Here's a patch which runs the broken test 1,000 times but incorporates the off-canvas fix from #3268680: [random test failure] Restore and fix LayoutBuilderDisableInteractionsTest::testFormsLinksDisabled().

Status: Needs review » Needs work

The last submitted patch, 5: 3272797-5-1000x.patch, failed testing. View results

xjm’s picture

xjm
she/her
Primary language English
commented

So the off-canvas fix does not fix it. :(

bnjmnm’s picture

bnjmnm
he/him
Primary language English
Location Ann Arbor, MI
commented
Status: Needs work » Needs review
StatusFileSize
new 3272797-8-1000x.patch5.65 KB
bnjmnm’s picture

bnjmnm
he/him
Primary language English
Location Ann Arbor, MI
commented
StatusFileSize
new interdiff_8-9.txt3.41 KB
new 3272797-9-1000x.patch5.89 KB

The data attribute removal is now built into the trait. It doesn't hurt having it there even when it isn't needed... and this issue demonstrates there are absolutely times where it is needed.

xjm’s picture

xjm
she/her
Primary language English
commented

I was about to upload a patch identical to #9, but I will settle for re-running the baseline. ;)

xjm’s picture

xjm
she/her
Primary language English
commented
StatusFileSize
new lb-3272797-11-fix-only.patch4.15 KB

Above test runs are pretty conclusive.

Here's a fix-only version for commit.

xjm’s picture

xjm
she/her
Primary language English
commented
Version: 9.4.x-dev » 9.3.x-dev
xjm’s picture

xjm
she/her
Primary language English
commented
Status: Needs review » Reviewed & tested by the community

#11 is just extracted from #9, so I can RTBC this. :)

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed ce4e8fa361 to 10.0.x and b0f5cfa203 to 9.4.x and a87055c118 to 9.3.x. Thanks!

  • alexpott committed ce4e8fa on 10.0.x 
    Issue #3272797 by bnjmnm, phenaproxima, xjm: [random test failure]...

  • alexpott committed b0f5cfa on 9.4.x 
    Issue #3272797 by bnjmnm, phenaproxima, xjm: [random test failure]...

  • alexpott committed a87055c on 9.3.x 
    Issue #3272797 by bnjmnm, phenaproxima, xjm: [random test failure]...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.