Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
This is part of #3267247: [meta] Fix and re-enable tests skipped for random failures, for LayoutBuilderTest::testConfigurableLayoutSections().
See the parent issue for steps to reproduce/proposed resolution.
Comments
Comment #2
phenaproximaComment #3
phenaproximaStandard procedure, let's start with a patch that un-skips the offending test and runs it 1,000 times.
Comment #5
phenaproximaHere's a patch which runs the broken test 1,000 times but incorporates the off-canvas fix from #3268680: [random test failure] Restore and fix LayoutBuilderDisableInteractionsTest::testFormsLinksDisabled().
Comment #7
xjmSo the off-canvas fix does not fix it. :(
Comment #8
bnjmnmComment #9
bnjmnmThe data attribute removal is now built into the trait. It doesn't hurt having it there even when it isn't needed... and this issue demonstrates there are absolutely times where it is needed.
Comment #10
xjmI was about to upload a patch identical to #9, but I will settle for re-running the baseline. ;)
Comment #11
xjmAbove test runs are pretty conclusive.
Here's a fix-only version for commit.
Comment #12
xjmComment #13
xjm#11 is just extracted from #9, so I can RTBC this. :)
Comment #14
alexpottCommitted and pushed ce4e8fa361 to 10.0.x and b0f5cfa203 to 9.4.x and a87055c118 to 9.3.x. Thanks!