Problem/Motivation

In #3257127: Trigger a deprecation message when a deprecated module or theme is enabled we excluded deprecated modules from various tests. In most cases this didn't really lose any coverage, but ResolvedLibraryDefinitionsFilesMatchTest could be refactored to have two test methods - one against stable modules without @group legacy, and one testing only deprecated modules with it.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#3 3270499-3.patch3.42 KBspokje

Issue fork drupal-3270499

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

catch created an issue. See original summary.

Spokje made their first commit to this issue’s fork.

spokje’s picture

spokje
Primary language Dutch
commented
StatusFileSize
new 3270499-3.patch3.42 KB
spokje’s picture

spokje
Primary language Dutch
commented

I _really_ don't understand why this still throws a deprecation notice, whilst in #3270323-12: ModuleConfigureRouteTest::testModuleConfigureRoutes fails for modules which have a configure route and are deprecated, where I do basically the same (load module in a test marked with @group legacy) doesn't.

Version: 10.0.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

quietone made their first commit to this issue’s fork.

quietone opened merge request !11884

quietone’s picture

quietone commented
Status: Active » Needs review

Reworked the patch a bit so there are two test methods.

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Appears to be a good refactor to me, with the 2 separate functions now.

  • alexpott committed d9535798 on 11.1.x 
    Issue #3270499 by spokje, quietone, catch: Add a deprecated module...

  • alexpott committed cf5008b1 on 11.2.x 
    Issue #3270499 by spokje, quietone, catch: Add a deprecated module...

  • alexpott committed b8c04763 on 11.x 
    Issue #3270499 by spokje, quietone, catch: Add a deprecated module...
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Version: 11.x-dev » 11.1.x-dev
Status: Reviewed & tested by the community » Fixed

Committed and pushed b8c04763730 to 11.x and cf5008b15b1 to 11.2.x and d9535798624 to 11.1.x. Thanks!

Backported to 11.1.x as this is a test-only change and makes it easier to backport things.

donquixote’s picture

donquixote commented

It appears this caused problems in 11.1.x.
See #3525090: [11.1] ResolvedLibraryDefinitionsFilesMatchTest is failing

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

quietone closed merge request !11884