Drupal 10 compatibility

I'll work on this.

Here is a patch. Kindly review it.

I will review this patch.

When i ran the drupal-check command after applying the patch, it didn't show any error messages. For this reason i believe that everything is right.
Moving to RTBC!

Hi! I just provided a new small patch to fix the test error.

One more small patch. The other problem happening on tests, unfortunately I don't know exactly how to solve it.

Needs work (still has failing tests).

Drupal 10.0 development

Following with

The current composer require status for this module under Drupal 10

composer create-project drupal/recommended-project:10.0.0-alpha4@alpha /var/www/html/sandboxes/drupal10allowed_formats
cd /var/www/html/sandboxes/drupal10allowed_formats/

composer require drupal/allowed_formats;

is having the following problem

Using version ^1.5 for drupal/allowed_formats
./composer.json has been updated
Running composer update drupal/allowed_formats
Loading composer repositories with package information
Updating dependencies
Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - Root composer.json requires drupal/allowed_formats ^1.5 -> satisfiable by drupal/allowed_formats[1.5.0, 1.x-dev].
    - drupal/allowed_formats[1.5.0, ..., 1.x-dev] require drupal/core ^8.8 || ^9 -> found drupal/core[8.8.0-alpha1, ..., 8.9.x-dev, 9.0.0-alpha1, ..., 9.5.x-dev] but the package is fixed to 10.0.0-alpha4 (lock file version) by a partial update and that version does not match. Make sure you list it as an argument for the update command.

Use the option --with-all-dependencies (-W) to allow upgrades, downgrades and removals for packages currently locked to specific versions.
You can also try re-running composer require with an explicit version constraint, e.g. "composer require drupal/allowed_formats:*" to figure out if any version is installable, or "composer require drupal/allowed_formats:^2.1" if you know which you need.

Installation failed, reverting ./composer.json and ./composer.lock to their original content.
<code>

<hr />
<h4>Farther <strong><a href="https://github.com/mglaman/drupal-check">drupal-check</a></strong> on</h4>

<code>
composer create-project drupal/recommended-project:~9 /var/www/html/sandboxes/drupal9allowed_formats

cd /var/www/html/sandboxes/drupal9allowed_formats/

composer require drupal/allowed_formats

composer require drupal/core-dev --with-all-dependencies
composer require mglaman/drupal-check --dev
composer require phpspec/prophecy-phpunit:^2 --dev 

php vendor/bin/drupal-check -d web/modules/contrib/allowed_formats/

Output:

allowed_formats--drupal-check--report.txt

 ------ ---------------------------------------------- 
  Line   allowed_formats.module                        
 ------ ---------------------------------------------- 
  20     Call to an undefined method                   
         Drupal\Core\Form\FormInterface::getEntity().  
 ------ ---------------------------------------------- 


 [ERROR] Found 1 error                                                          

Fixed all issues Please review my patch.
I am sharing with you a screenshot of the result.

+++ b/allowed_formats.module
@@ -11,13 +11,17 @@ use Drupal\Core\Form\FormStateInterface;
  */
 function allowed_formats_form_field_config_edit_form_alter(array &$form, FormStateInterface $form_state) {
-  /** @var \Drupal\Core\Field\FieldConfigInterface $field */
-  $field = $form_state->getFormObject()->getEntity();
+
+  $form_object = $form_state->getFormObject();
+  if ($form_object instanceof EntityFormInterface) {
+    /** @var \Drupal\Core\Field\FieldConfigInterface $field */
+    $field = $form_object->getEntity();
 

This is not about Drupal 10 compatibility, drupal-check now includes more strict phpstan checks and not only
d10 related issues. It could be kept if it's a small thing, but it either needs to be rewritten or the whole section inside would need to be indented.

I went back to #8 which has more fixes anyway and fixed the tests because on change is missing. The tools don't report on the subtle but important hook rename that this module relies on. That also means we require at least Drupal 9.2

The CR for the hook rename that #14 refers to: https://www.drupal.org/node/3180429.

hi, i'll review it :)

hi!

I reviewed the last patch and all it didn't show any warnings or errors.
The correction mentioned on #15 was already made on the patch. I believe everything is right, so I'm changing it to RTBC.

Thanks for the patch and testing.

@tauanygb Did you test on Drupal 9 or 10 or both?

@Kristen Pol I tested it on a Drupal 9 environment, and ran drupal-check.

Additional +1 RTBC to #14. Manually tested against 10.0.x-dev and 9.5.x-dev; the patch and automated test results look great.

Thank you all for the work on this issue. This has been committed to the dev version and will be included in the next release.

@nord102, could you, please, tag a new release to include this change?

@claudiu.cristea

I have tagged a new release for this