Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.Problem/Motivation
Because of #3083275: [meta] Update tests that rely on Classy to not rely on it anymore and Classy being deprecated in Drupal 9 + removed in Drupal 10,: Tests that aren't specifically testing Classy yet declare $defaultTheme = 'classy'; should be refactored to use Stark as the default theme instead.
Proposed resolution
Change all tests in this module to use Stark as the default theme, and refactor the tests where needed so they continue to function properly.
Remaining tasks
User interface changes
API changes
Data model changes
Release notes snippet
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | 3268708-2.patch | 4.62 KB | danflanagan8 |
Comments
Comment #2
danflanagan8This one was surprisingly tricky considering only one class ended up needing any substantive changes
For one, it asserted the presence of an element in a very strange way:
That escaped my initial search for
cssandxpath. And obviously that assertion relies strongly on Classy.The bigger thing though was that I felt compelled to channel @xjm and really make sure that the assertions I updated are truly asserting what they claim. So there's more to the diff than just changing selectors. But I think my changes here are very much in line with @xjm's feedback on the sibling Taxonomy issue.
Comment #3
longwaveI like that the test is easier to read and clarifies exactly what it is looking for now, so +1 to the changes.
Comment #6
lauriiiNice improvements to the assertions. Feels like this should a lot less brittle than the original assertions.
Committed 801e645 and pushed to 10.0.x. Also cherry-picked to 9.4.x. Thanks!