Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Comments

alexpott created an issue. See original summary.

alexpott’s picture

Status: Active » Needs review
StatusFileSize
new1.76 KB
new3.15 KB
new1.39 KB
alexpott’s picture

StatusFileSize
new71.37 KB
new66.54 KB

#2 is not working. Let's skip the test for now and revisit.

Here's screenshot of a pass

... and fail...

Why the difference?

alexpott’s picture

StatusFileSize
new761 bytes

Here's a patch to skip the test

spokje’s picture

On "Spot-the-difference" in #3:

- The QuickEdit-popup with "Llama" has "Body ->" as a prefix in the Pass

INSTA-EDIT: O _why_ the difference, not _what's_ :/

longwave’s picture

Status: Needs review » Reviewed & tested by the community

Let's just add this to the skip list for now and revisit it later.

On the bright side this problem will go away when we remove Quick Edit from core :)

spokje’s picture

Since quickedit is on it's way out (of core) anyway,
- and the failing test does make all tested versions fail,
- and skipping the whole test would prevent that.

RTCB if TestBot agrees, which it basically already did in #2

xjm’s picture

Version: 10.0.x-dev » 9.2.x-dev
Issue tags: +Needs followup

I'm fine with skipping the test for now, but we should file a followup issue to look into it. Drupal 9.4 has to support QuickEdit until November 2023.

longwave’s picture

We should probably do it as part of #3267247: [meta] Fix and re-enable tests skipped for random failures where we are planning to fix other tests we skipped this week.

  • xjm committed 0008a82 on 10.0.x
    Issue #3267823 by alexpott, Spokje: \Drupal\Tests\quickedit\...
alexpott’s picture

@longwave well amusingly these test fails are caused by the update of chromedriver.

  • xjm committed 68c95d0 on 9.4.x
    Issue #3267823 by alexpott, Spokje: \Drupal\Tests\quickedit\...

  • xjm committed 7ce0090 on 9.3.x
    Issue #3267823 by alexpott, Spokje: \Drupal\Tests\quickedit\...

  • xjm committed 8283428 on 9.2.x
    Issue #3267823 by alexpott, Spokje: \Drupal\Tests\quickedit\...
xjm’s picture

Priority: Critical » Major
Status: Reviewed & tested by the community » Needs work

Okay, committed to all four branches. We can leave this issue open (but downgrade it to major) to get the test working again.

xjm’s picture

Priority: Major » Critical
Status: Needs work » Fixed

Ah, if there's already a followup, that's fine too. Thanks!

xjm’s picture

Issue tags: -Needs followup
xjm’s picture

Issue tags: +Random test failure

This was like an 80% fail rate, not 100%, so tagging accordingly.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.