Problem/Motivation

Currently the admin permission for the fragment_type entity is "administer site configuration". Not sure if this is done intentionally, but there is also an unused permission "administer fragment types" in the module.

Proposed resolution

It is probably better to use a custom "administer fragment types" permission instead of a generic permission "administer site configuration". Specially since it already exists :)

Release note snippet

In previous versions, the module used the administer site configuration permission to control access to administering fragments types. The module also included a permission "administer fragment types", but it didn't do anything. Please review your roles and make sure that any roles that need to be able to administer fragment types have the "administer fragment types" permission.

CommentFileSizeAuthor
#2 3267668-2.patch482 bytesseanb

Issue fork fragments-3267668

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

seanB created an issue. See original summary.

seanb’s picture

Status: Active » Needs review
StatusFileSize
new482 bytes

Patch is attached.

eelkeblok’s picture

Issue summary: View changes

Thanks. I agree this must be an oversight. I was wondering if it would make sense to do an update hook, but given that the permission already exists, people may already be relying on it and auto-assigning it to roles that only have "administer site configuration" is probably a bad idea.

Added release notes snippet.

seanb’s picture

Yeah, also not sure if this is worth the update hook effort. I think creating new fragment types is something developers (or at least people with a lot of permissions) do most of the time anyway.

  • eelkeblok committed af9f5f9 on 2.x authored by seanB
    Issue #3267668 by seanB, eelkeblok: Use the "administer fragment types"...
eelkeblok’s picture

Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.