Add formatter for https://www.npr.org/ videos.
Review and test
GTR18 created an issue. See original summary.
Thank you for contributing! I think we are almost there, I just found a few nitpicks with the code but after that we'll be good to go.
+++ b/media_remote.module @@ -65,6 +65,14 @@ function media_remote_theme($existing, $type, $theme, $path) { + 'type' => NULL,
Are we using this `type` variable or is it just leftover from other formatters?
+++ b/src/Plugin/Field/FieldFormatter/MediaRemoteNPRFormatter.php @@ -0,0 +1,127 @@ + '#type' => $matches[1][0],
Again, do we need the type here?
+++ b/templates/media-remote-npr.html.twig @@ -0,0 +1,14 @@ + * Template implementation for the media_remote_buzzsprout theme hook.
Copy/paste leftover?
+++ b/templates/media-remote-npr.html.twig @@ -0,0 +1,14 @@ + * - type: (string) The type of this content: document, spreadsheets or
We don't seem to be using the type, we could just remove it here I think.
Issue #3265320 by GTR18, marcoscano: Add support for NPR
Looks great, thanks for contributing!
Automatically closed - issue fixed for 2 weeks with no activity.
Comments
Comment #2
gtr18 commentedComment #3
marcoscanoThank you for contributing! I think we are almost there, I just found a few nitpicks with the code but after that we'll be good to go.
Are we using this `type` variable or is it just leftover from other formatters?
Again, do we need the type here?
Copy/paste leftover?
We don't seem to be using the type, we could just remove it here I think.
Comment #4
gtr18 commentedComment #5
gtr18 commentedComment #6
gtr18 commentedComment #8
marcoscanoLooks great, thanks for contributing!