Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Problem/Motivation
Discovered while working on #3224652: [drupalImage] Add ckeditor5-image's imageresize plugin to allow image resizing.
$assert_session->waitForElementVisible('css', '.figure.image')
is wrong, it should be figure.image
.
Steps to reproduce
N/A
Proposed resolution
- Assert the result: guarantees the selector works; should fail tests
- Fix selector; should make tests pass again
Remaining tasks
Review
User interface changes
N/A
API changes
N/A
Data model changes
N/A
Release notes snippet
N/A
Issue fork drupal-3264451
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #3
Wim LeersComment #4
Wim LeersShould be easy and zero risk to cherry-pick back to
9.4.x
and9.3.x
. Not posting separate patches for that reason.Comment #5
bnjmnmStraightforward fix, and who among us hasn't overlooked asserting
waitForElementVisible()
. Some test methods have the assert built in, and some don't, and it's great when we catch it quick so 👍 👍 👍 👍 👍Comment #8
lauriiiCommitted b45b2bd and pushed to 10.0.x. Also cherry-picked to 9.4.x. Thanks!
Leaving open for a 9.3.x backport until freeze is over.
Comment #10
lauriiiCherry-picked to 9.3.x.