Problem/Motivation

Discovered while working on #3224652: [drupalImage] Add ckeditor5-image's imageresize plugin to allow image resizing.

$assert_session->waitForElementVisible('css', '.figure.image')

is wrong, it should be figure.image.

Steps to reproduce

N/A

Proposed resolution

  1. Assert the result: guarantees the selector works; should fail tests
  2. Fix selector; should make tests pass again

Remaining tasks

Review

User interface changes

N/A

API changes

N/A

Data model changes

N/A

Release notes snippet

N/A

Issue fork drupal-3264451

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Wim Leers created an issue. See original summary.

Wim Leers’s picture

Status: Active » Needs review
Wim Leers’s picture

Should be easy and zero risk to cherry-pick back to 9.4.x and 9.3.x. Not posting separate patches for that reason.

bnjmnm’s picture

Status: Needs review » Reviewed & tested by the community

Straightforward fix, and who among us hasn't overlooked asserting waitForElementVisible(). Some test methods have the assert built in, and some don't, and it's great when we catch it quick so 👍 👍 👍 👍 👍

  • lauriii committed b45b2bd on 10.0.x
    Issue #3264451 by Wim Leers, bnjmnm: ImageTest::testWidth() has wrong...

  • lauriii committed 92c54ef on 9.4.x
    Issue #3264451 by Wim Leers, bnjmnm: ImageTest::testWidth() has wrong...
lauriii’s picture

Version: 10.0.x-dev » 9.3.x-dev

Committed b45b2bd and pushed to 10.0.x. Also cherry-picked to 9.4.x. Thanks!

Leaving open for a 9.3.x backport until freeze is over.

  • lauriii committed b5c61db on 9.3.x
    Issue #3264451 by Wim Leers, bnjmnm: ImageTest::testWidth() has wrong...
lauriii’s picture

Status: Reviewed & tested by the community » Fixed

Cherry-picked to 9.3.x.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.