Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.Problem/Motivation
From the phpstan baseline.
in the error handling for CKEditor5ImageController, sprintf is missing one of its arguments leading to a less than helpful error message. This seems to have been copied from other places with the same logic but somehow it as lost?
Steps to reproduce
outside of testing and static analysis this would be tricky to recreate as its in the lock handling.
Proposed resolution
Remaining tasks
User interface changes
API changes
Data model changes
Release notes snippet
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | 3264153-1.patch | 2.82 KB | neclimdul |
Comments
Comment #2
neclimdulComment #3
wim leersSeems like a safe & sound fix! Queued tests for
9.4.xand9.3.xbecause CKEditor 5 is experimental and is getting every patch cherry-picked to both of those branches too.Comment #7
catchThe phpstan changes don't apply to the 9.4.x/9.3.x branches, but everything else does. Committed/pushed to 10.0.x, then to 9.4.x/9.3.x with that hunk removed. Thanks!
Comment #8
wim leersPerfect, thanks @catch!