Just tried version 2.0.0 on simpletest.me but doesn't work:

 [success] Installation complete.
62027aaaf8ba3c5cfa8bdd2e# /bin/sh -c cd "${DOCROOT}" && ../vendor/bin/drush en ga_webform -y
The following module(s) will be enabled: ga_webform, ga, webform
// Do you want to continue?: yes.
[warning] Declaration of Drupal\webform\EventSubscriber\WebformExceptionHtmlSubscriber::on403(Symfony\Component\HttpKernel\Event\GetResponseForExceptionEvent $event) should be compatible with Drupal\Core\EventSubscriber\DefaultExceptionHtmlSubscriber::on403(Symfony\Component\HttpKernel\Event\ExceptionEvent $event) WebformExceptionHtmlSubscriber.php:31
[warning] Declaration of Drupal\webform\EventSubscriber\WebformExceptionHtmlSubscriber::onException(Symfony\Component\HttpKernel\Event\GetResponseForExceptionEvent $event) should be compatible with Drupal\Core\EventSubscriber\HttpExceptionSubscriberBase::onException(Symfony\Component\HttpKernel\Event\ExceptionEvent $event) WebformExceptionHtmlSubscriber.php:31
In Container.php line 156:
                                                               
  You have requested a non-existent service "entity.manager".
Command Failed (Tugboat Error 1064): Exit code (1)

Thanks!

CommentFileSizeAuthor
Screenshot-202202081626-789x758.png163.04 KBgge

Comments

gge created an issue. See original summary.

agoradesign’s picture

The problem here is, that webform 5.13 is quite ancient already. And that this webform version is wrongly classified as Drupal 9.x compatible, although it isn't. So the bug comes from webform, but I'll change the version constraint in composer.json, which must be done anyway, since we'll want to support webform 6.x of course

  • agoradesign committed 44c861f on 2.x
    Issue #3263152 by gge, agoradesign: Doesn\'t work with Webform 8.x-5.13
    
agoradesign’s picture

Status: Active » Fixed

tagged a new release 2.0.1

however I recommend using Google Tag Manager (there's the Drupal module google_tag) instead of direct integration of GA. At least we do so for quite a while now, which also means that I won't work actively on this module anymore at all... only small fixes like that one

gge’s picture

Thank you!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.