Problem/Motivation

migrate_drupal_multilingual was deprecated back in #2966856: Hide and disable Drupal Migrate Multilingual, but back then we did not have a proper mechanism for deprecating and removing modules. Following child issues of #3135100: [policy and meta] Provide a proper mechanism for deprecating modules and themes we have a way of doing this now, so we should update migrate_drupal_multilingual to match and remove it in Drupal 10.

Steps to reproduce

Proposed resolution

Deprecate migrate_drupal_multilingual correctly in 9.4.x.
Remove migrate_drupal_multilingual in 10.0.x.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#2 3261957-2.patch2.79 KBlongwave
#6 3261957-6.patch11.31 KBlongwave

Comments

longwave created an issue. See original summary.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Active » Needs review
StatusFileSize
new 3261957-2.patch2.79 KB
quietone’s picture

quietone commented

This is already done in #3261004: Remove deprecated code from the migration system , comment #7.

catch’s picture

catch
he/him
Primary language English
commented

Marked #3261961: Mark migrate_drupal_multilingual obsolete as duplicate.

Status: Needs review » Needs work

The last submitted patch, 2: 3261957-2.patch, failed testing. View results

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Needs work » Needs review
StatusFileSize
new 3261957-6.patch11.31 KB

Remove all remaining references to migrate_drupal_multilingual except the code that uninstalls it and the test for that.

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Needs review » Reviewed & tested by the community

I think it better to get this fix first as it does clean-up mentions as well

@quietone the issue just changing life-cycle but the #3261004-7: Remove deprecated code from the migration system will *remove* and technically could be done only after current issue

andypost’s picture

andypost
he/him
Primary language Russian
commented
Related issues: +#2966859: Remove Migrate Drupal Multilingual module in Drupal 10

The removal issue is #2966859: Remove Migrate Drupal Multilingual module in Drupal 10

quietone’s picture

quietone commented

@andypost, thanks. I posted that just before I went to sleep and didn't think about it enough.

According to this comment modules being marked obsolete needs an update to uninstall it. That is not in the patch because it already exists, \migrate_drupal_post_update_uninstall_multilingual

  • catch committed 258c837 on 10.0.x 
    Issue #3261957 by longwave, quietone, andypost: Properly deprecate...

  • catch committed 6f1a617 on 9.4.x 
    Issue #3261957 by longwave, quietone, andypost: Properly deprecate...
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 10.0.x and cherry-picked to 9.4.x, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.