Problem/Motivation

Alpha4 uses the service \Drupal::service('file_url_generator'), which is new in Drupal 9.3.x and not availbable in prior versions.

Steps to reproduce

Run Alpah4 on Drupal 8 or Drupal 9.1/9.2

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork responsive_background_image-3261940

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

slowflyer created an issue. See original summary.

slowflyer’s picture

slowflyer commented
Issue summary: View changes
maskedjellybean’s picture

maskedjellybean
Location Portland, OR
commented

Thank you @slowflyer. I think the work around for now would be to use alpha3 if your core version is less than 9.3.x:

composer require drupal/responsive_background_image:1.0.0-alpha3

@Anybody do you know, would the proper solution for this be to create a new release where core_version_requirement: ^9.3 in responsive_background_image.info.yml and "drupal/core": "^9.3", in composer.json?

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Assigned: Unassigned » anybody

Thank you and sorry, I'll have a look!

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented

Ok here's the plan. I'll revert that change for an alpha-5 release and afterwards create a new 2.x semver version which has compatibility starting with Drupal 9.3!

2.x will then be the recommended version but 8.x-1.x still be available for old installations.
Thanks and sorry for the trouble, I didn't see this problem coming. -.-

  • Anybody committed 85a5ecd on 8.x-1.x 
    Issue #3261940 by Anybody, slowflyer, maskedjellybean: Lost...

  • Anybody committed 0a3a059 on 8.x-1.x 
    Issue #3261940 by Anybody, snowflyer, maskedjellybean: Lost...
anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented

I'm the one to blame, found the related commit:
https://git.drupalcode.org/project/responsive_background_image/-/commit/...

Changing back to old:

file_url_transform_relative()

Anybody opened merge request !3

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Version: 8.x-1.0-alpha4 » 8.x-1.x-dev
Status: Active » Needs review

Here we go. I'll fix this in 8.x-1.x-dev now. @slowflyer could you please check if 8.x-1.x-dev works correctly for you? Then we can create an 8.x-1.0-alpha5 release from that.

Sorry all.

  • Anybody committed 64172d6 on 8.x-1.x 
    Issue #3261940 by Anybody: Lost compatibility to Drupal 8 and Drupal 9.1...
anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Assigned: anybody » Unassigned
anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Needs review » Fixed
slowflyer’s picture

slowflyer commented

Hi,

8.x-1.x-dev works correctly!

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented

Thanks @slowflyer, I'll create the alpha-5 then now :)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.