Problem/Motivation

Halite supported version 5.0.0 13 days ago and they seem to have marked ^4.0 unsupported.

Steps to reproduce

https://github.com/paragonie/halite/releases/tag/v5.0.0#installing-halite

Proposed resolution

Since 5.0 requires 8.0 and that might be a problem I guess allow both 4 and 5?

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#9 3261826-9.patch360 bytesrlhawk
#8 3261826-8.patch368 bytesrlhawk
#5 3261826-5.patch302 bytesrlhawk
#3 3261826-3.patch299 bytesrlhawk

Comments

neclimdul created an issue. See original summary.

rlhawk’s picture

rlhawk
Primary language English
Location Seattle, Washington, United States
commented

I created a branch for a new major version of Sodium that will require Drupal 10, PHP 8.1, and Halite 5.1+. For the 2.x version of Sodium, we will need to allow Halite 4.1 and 5+.

rlhawk’s picture

rlhawk
Primary language English
Location Seattle, Washington, United States
commented
Status: Active » Needs review
StatusFileSize
new 3261826-3.patch299 bytes

Here's a patch that adds support for Halite 5+. I tested it with PHP 7.4, 8.0, and 8.1, on Drupal 9.4.3. The correct Halite version was installed and I was able to encrypt and decrypt text as expected in every case.

Status: Needs review » Needs work

The last submitted patch, 3: 3261826-3.patch, failed testing. View results

rlhawk’s picture

rlhawk
Primary language English
Location Seattle, Washington, United States
commented
StatusFileSize
new 3261826-5.patch302 bytes
rlhawk’s picture

rlhawk
Primary language English
Location Seattle, Washington, United States
commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 5: 3261826-5.patch, failed testing. View results

rlhawk’s picture

rlhawk
Primary language English
Location Seattle, Washington, United States
commented
Status: Needs work » Needs review
StatusFileSize
new 3261826-8.patch368 bytes
rlhawk’s picture

rlhawk
Primary language English
Location Seattle, Washington, United States
commented
StatusFileSize
new 3261826-9.patch360 bytes

  • rlhawk committed 5da36fd on 8.x-2.x 
    Issue #3261826 by rlhawk, neclimdul: Halilte pinned to unsupported...
rlhawk’s picture

rlhawk
Primary language English
Location Seattle, Washington, United States
commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.