Problem/Motivation
Discovered while reviewing #3260554: [drupalMedia] Support alignment on <drupal-media>, see https://git.drupalcode.org/project/drupal/-/merge_requests/1719/diffs#no....
We have no test coverage at all proving that sites using media_embed and the DrupalMediaLibrary button get upgraded as expected.
Steps to reproduce
N/A
Proposed resolution
N/A
Remaining tasks
Review.
User interface changes
N/A
API changes
N/A
Data model changes
N/A
Release notes snippet
N/A
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | 3261712-5.patch | 4.21 KB | wim leers |
| #5 | interdiff.txt | 1.31 KB | wim leers |
| #3 | 3261712-3.patch | 4.45 KB | wim leers |
| #3 | interdiff.txt | 755 bytes | wim leers |
| #2 | 3261712-2.patch | 4.45 KB | wim leers |
Comments
Comment #2
wim leersComment #3
wim leersComment #4
bnjmnmThe only config property needed for this test is
'status' => TRUE, while the additional config is not doing any harm, I prefer not adding anything that isn't directly relevant to the test.Comment #5
wim leersThose settings are copied 1:1 from the annotation of
\Drupal\media\Plugin\Filter\MediaEmbed— they’re exactly the defaults.IIRC there were some problems with not passing valid configuration to plugins. But … in this case, it seems to work just fine if I omit them. So, did what you asked :)
Comment #6
bnjmnmRe #5
That pretty much lines up with my suspicions regarding why it was there because they certainly looked like default values. It may have zero impact long term, but I like that the test demonstrates that
'status' => TRUEis the only property relevant to that part of the process. Thanks for indulging the preference 😎Comment #10
lauriiiCommitted c715824 and pushed to 10.0.x. Also cherry-picked to 9.4.x and 9.3.x because CKEditor 5 is experimental. Thanks!