Problem/Motivation

There are a bunch of PHP files in the Transliteration component: https://git.drupalcode.org/project/drupal/-/tree/9.4.x/core/lib/Drupal/C...

We should have PHPStan ignore them to speed up analysis bit a smidge and reduce memory.

Steps to reproduce

Scan with --debug and notice all of these files

Proposed resolution

Add ignore of core/lib/Drupal/Component/Transliteration/data/*.php

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Issue fork drupal-3261613

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

mglaman created an issue. See original summary.

mglaman opened merge request !1753

mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented
Status: Active » Needs review
Issue tags: +PHPStan

This may not have the biggest impact, but it helps.

mondrake’s picture

mondrake
Location 🇮🇹
commented
Status: Needs review » Reviewed & tested by the community

This makes sense to me

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed e446d19 and pushed to 10.0.x. Thanks!

  • alexpott committed e446d19 on 10.0.x 
    Issue #3261613 by mglaman: Ignore transliteration data when scanning...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.