Problem/Motivation

UpdateUploaderTestBase is test base class but not declared abstract. It's causing the following error with PHPStan

		-
			message: "#^Drupal\\\\Tests\\\\BrowserTestBase\\:\\:\\$defaultTheme is required\\. See https\\://www\\.drupal\\.org/node/3083055, which includes recommendations on which theme to use\\.$#"
			count: 1
			path: modules/update/tests/src/Functional/UpdateUploaderTestBase.php

Steps to reproduce

Scan modules/update/tests/src/Functional/UpdateUploaderTestBase.php. Errors about $defaultTheme but abstract classes are ignored for this error. Make abstract, no error.

Proposed resolution

Make it abstract

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Issue fork drupal-3260710

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

mglaman created an issue. See original summary.

mglaman opened merge request !1722

mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented
Status: Active » Needs review
longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Needs review » Reviewed & tested by the community

Great to see PHPStan finding little bugs like this.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Version: 10.0.x-dev » 9.4.x-dev
Status: Reviewed & tested by the community » Fixed

Committed 6eb57f0 and pushed to 10.0.x. Thanks!
Committed 5996407 and pushed to 9.4.x. Thanks!

  • alexpott committed 6eb57f0 on 10.0.x 
    Issue #3260710 by mglaman: UpdateUploaderTestBase must be declared...

  • alexpott committed 5996407 on 9.4.x 
    Issue #3260710 by mglaman: UpdateUploaderTestBase must be declared...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.