Problem/Motivation

Discovered in #3161889-221: [META] Symfony 6 compatibility, run-tests.sh calls \Drupal::service('app.root'), which is deprecated in favour of a container parameter.

Steps to reproduce

Proposed resolution

Use \Drupal::root() instead.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#2 3258995-2.patch1.02 KBlongwave

Comments

longwave created an issue. See original summary.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Active » Needs review
StatusFileSize
new 3258995-2.patch1.02 KB
daffie’s picture

daffie commented
Status: Needs review » Reviewed & tested by the community

Looks good to me.

  • catch committed 6d8f206 on 10.0.x 
    Issue #3258995 by longwave: run-tests.sh uses the deprecated app.root...

  • catch committed e73cbf5 on 9.4.x 
    Issue #3258995 by longwave: run-tests.sh uses the deprecated app.root...
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed 6d8f206 and pushed to 10.0.x. Thanks! Also cherry-picked to 9.4.x

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.