I Installed dev verision of Linkchecker Summary Mail M Module but I do not have option to access admin page at /admin/config/content/linkchecker_summary_mail. This was the same case when I installed 7.x-1.2.

I do not see any permissions for admin apart from link checker module. What Am I missing? Please advise.

Thanks
Akshita

CommentFileSizeAuthor
#13 linkchecker_summary_mail-3257871-13.patch3.77 KBreenaraghavan
#10 3257871-10.patch1.5 KBshashwat purav
#8 3257871-8.patch1.14 KBshashwat purav
#5 3257871-5.patch918 bytesshashwat purav
linkcheker-permissions.PNG11.24 KBakshita

Issue fork linkchecker_summary_mail-3257871

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Akshita created an issue. See original summary.

eiriksm’s picture

eiriksm
he/him
Primary language Norwegian Bokmål
Location Norway
commented
Component: User interface » Code
Category: Feature request » Bug report
Priority: Critical » Major

There does indeed seem to be missing a permission for this module. If you log in as user 1 that page would work.

Happy to accept any patches or merge requests for a fix? 🤓

akshita’s picture

akshita commented

Thank you. That was I figured out too. Logged in as super user to set the configurations of the module.

eiriksm’s picture

eiriksm
he/him
Primary language Norwegian Bokmål
Location Norway
commented
Issue tags: +Novice

Tagging as novice. Task would be to add the permission as part of this module.

shashwat purav’s picture

shashwat purav commented
Version: 7.x-1.x-dev » 2.0.x-dev
Status: Active » Needs review
StatusFileSize
new 3257871-5.patch918 bytes

Added patch for the permission to access admin page.

eiriksm’s picture

eiriksm
he/him
Primary language Norwegian Bokmål
Location Norway
commented
Version: 2.0.x-dev » 7.x-1.x-dev

That's very good, and thank you for that.

However, this issue is about the drupal 7 version

jeroent’s picture

jeroent
Primary language Dutch
Location 🇧🇪
commented
Status: Needs review » Needs work
shashwat purav’s picture

shashwat purav commented
Status: Needs work » Needs review
StatusFileSize
new 3257871-8.patch1.14 KB

Created patch for Drupal 7 version.

Status: Needs review » Needs work

The last submitted patch, 8: 3257871-8.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

shashwat purav’s picture

shashwat purav commented
Status: Needs work » Needs review
StatusFileSize
new 3257871-10.patch1.5 KB

Fixed coding standards.

Status: Needs review » Needs work

The last submitted patch, 10: 3257871-10.patch, failed testing. View results

reenaraghavan’s picture

reenaraghavan commented
Assigned: Unassigned » reenaraghavan
reenaraghavan’s picture

reenaraghavan commented
Assigned: reenaraghavan » Unassigned
Status: Needs work » Needs review
StatusFileSize
new linkchecker_summary_mail-3257871-13.patch3.77 KB

Attached patch

jeroent’s picture

jeroent
Primary language Dutch
Location 🇧🇪
commented
Status: Needs review » Reviewed & tested by the community

@reenaraghavan,

This issue is about the Drupal 7 version, your patch contains some Drupal 9 code.

The patch in #10 looks good to me.

Nitpick: should we revert this on commit? Since this is an unrelated change?

+++ b/linkchecker_summary_mail.module
@@ -61,7 +72,7 @@ function linkchecker_summary_mail_cron() {
- * @param int|boolean $last_checked
+ * @param int|bool $last_checked

  • eiriksm committed aea508e on 7.x-1.x 
    Issue #3257871 by Shashwat Purav, reenaraghavan, Akshita, eiriksm,...
eiriksm’s picture

eiriksm
he/him
Primary language Norwegian Bokmål
Location Norway
commented
Status: Reviewed & tested by the community » Fixed

Thanks everyone.

Nitpick: should we revert this on commit? Since this is an unrelated change?

Agreed, I did just that

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.