Problem/Motivation

Even when content of an icon sprite sheet changes, the cache-busting query hash can remain the same. This is due to generation of the hash using only some plugin data but not the actual file data.

Steps to reproduce

  1. Create a sprite sheet with some icons.
  2. Render an icon, taking note of the cache-busting hash
  3. Change content of the sprite sheet, without changing any viewboxes (just the path content)
  4. Clear the Drupal cache, see that the hash remains the same

Proposed resolution

Use the file content to generate the hash.

Remaining tasks

Make the patch.

Issue fork ex_icons-3256934

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

Wongjn created an issue. See original summary.

  • Wongjn committed 4fe67d9 on 8.x-1.x
    Issue #3256934 by Wongjn: Ensure Cache-busting hash updates when content...
wongjn’s picture

Status: Active » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.