Problem/Motivation

Functionality for using different join methods is hardcoded only for groups.

Steps to reproduce

  1. Define your entity type in the "social_group_join_method_usage" hook.
  2. When you log in as CM+ and navigate to the entity creation page then you should see the "Join methods" field in the "Settings" section.
  3. Join methods functionality for your entity type should work similarly to the same functionality for groups.
  4. Join methods functionality for groups should work as before.

Proposed resolution

Delete hard relationships to groups to be able to use it for different entity types.

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

chmez created an issue. See original summary.

ohorbatiuk’s picture

Assigned: ohorbatiuk » Unassigned
Status: Needs work » Needs review
ohorbatiuk’s picture

StatusFileSize
new2.85 KB
ohorbatiuk’s picture

StatusFileSize
new2.85 KB

Simplify field name for entity type identifier in a hook for defining supported join methods.

ohorbatiuk’s picture

Version: 4.0.0 » 4.0.2
Assigned: Unassigned » ohorbatiuk
Status: Needs review » Needs work
StatusFileSize
new5.46 KB

Allow selecting only one join method and ensure that the fieldset has a tooltip before modifying the second one.

ohorbatiuk’s picture

Issue summary: View changes
Parent issue: » #3254715: Make join methods for groups re-usable
StatusFileSize
new31.51 KB
  1. Restore the original order of join methods in the field for selecting the allowed method on the course creation/edit page.
  2. Delete redundant markup of the statistics block and restore buttons for accepting or declining an invitation.
  3. Restore the possibility of joining to course directly by an anonymous user.
ohorbatiuk’s picture

Assigned: ohorbatiuk » Unassigned
Status: Needs work » Needs review

  • ribel committed 2cb5618 on issue/social_course-3256927-feature/3256927-re-use-group-join-methods
    Issue #3256927: Add dependency from Open Social ^11.4.0-alpha2 and...
  • chmez committed 5e043da on issue/social_course-3256927-feature/3256927-re-use-group-join-methods
    Issue #3256927 by chmez: Simplify field name for entity type identifier...
  • chmez committed 70241d3 on issue/social_course-3256927-feature/3256927-re-use-group-join-methods
    Issue #3256927 by chmez: Ensure that the fieldset has a tooltip before...
  • chmez committed 73f0c0f on issue/social_course-3256927-feature/3256927-re-use-group-join-methods
    Issue #3256927 by chmez: Add patch for installation profile
    
  • chmez committed 7fccbbe on issue/social_course-3256927-feature/3256927-re-use-group-join-methods
    Issue #3256927 by chmez: Make an order of join methods in the field for...
  • chmez committed c68d323 on issue/social_course-3256927-feature/3256927-re-use-group-join-methods
    Issue #3256927 by chmez: Restore the original order of join methods in...
  • chmez committed c96c031 on issue/social_course-3256927-feature/3256927-re-use-group-join-methods
    Issue #3256927 by chmez: Replace dynamic patch with static
    
  • chmez committed df204de on issue/social_course-3256927-feature/3256927-re-use-group-join-methods
    Issue #3256927 by chmez: Restore the possibility of joining to course...
  • chmez committed dfdcc03 on issue/social_course-3256927-feature/3256927-re-use-group-join-methods
    Issue #3256927 by chmez: Delete redundant markup of the statistics block...
  • chmez committed e9fc2ab on issue/social_course-3256927-feature/3256927-re-use-group-join-methods
    Issue #3256927 by chmez: Use a new hook for detecting which group types...
  • chmez committed fac2f80 on issue/social_course-3256927-feature/3256927-re-use-group-join-methods
    Issue #3256927 by chmez: Allow selecting only one join method
    

ribel made their first commit to this issue’s fork.

  • chmez committed 5e043da on 4.1.x
    Issue #3256927 by chmez: Simplify field name for entity type identifier...
  • chmez committed 70241d3 on 4.1.x
    Issue #3256927 by chmez: Ensure that the fieldset has a tooltip before...
  • chmez committed 73f0c0f on 4.1.x
    Issue #3256927 by chmez: Add patch for installation profile
    
  • chmez committed 7fccbbe on 4.1.x
    Issue #3256927 by chmez: Make an order of join methods in the field for...
  • chmez committed c68d323 on 4.1.x
    Issue #3256927 by chmez: Restore the original order of join methods in...
  • chmez committed c96c031 on 4.1.x
    Issue #3256927 by chmez: Replace dynamic patch with static
    
  • chmez committed df204de on 4.1.x
    Issue #3256927 by chmez: Restore the possibility of joining to course...
  • chmez committed dfdcc03 on 4.1.x
    Issue #3256927 by chmez: Delete redundant markup of the statistics block...
  • ribel committed e777655 on 4.1.x
    Issue #3256927: Add dependency from Open Social 11.4.0-alpha2 and remove...
  • chmez committed e9fc2ab on 4.1.x
    Issue #3256927 by chmez: Use a new hook for detecting which group types...
  • chmez committed fac2f80 on 4.1.x
    Issue #3256927 by chmez: Allow selecting only one join method
    
ribel’s picture

Status: Needs review » Fixed

This change was merged and released in version 4.1.0

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.