Problem/Motivation
For accessibility purposes, the iframe that is rendered by this module in media-libsyn-embed.html.twig should have a "title" attribute that describes what the iframe contains. See: this section of the MDN documentation on iframes or the WCAG guidelines.
Steps to reproduce
The general steps to setup and configure the module and output a Libsyn podcast entity embed for this module. View the source of the output for the Libsyn embed: no title attribute is included. Compare this iframe to the iframes on the actual Libsyn website: they include the podcast episode's name in the "title" attribute.
Proposed resolution
Perhaps provide a way to include the podcast entity's title into the embed as a Twig variable for inclusion in media-libsyn-embed.html.twig? Or, recommend a way to include it via the template_preprocess_media_libsyn_embed function. I'm not really sure what method would be best.
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | iframe-title-3252322-3.patch | 3.24 KB | ahebrank |
Comments
Comment #2
ahebrank commentedChanging to a feature request. It looks like the source scraper will need to be modified to get the title of the libsyn embed, which isn't currently stored. Once that title is there it should be pretty simple to modify the preprocessing / template.
Comment #3
ahebrank commented@dalemoore try this out.
Comment #4
dalemoore commented@ahebrank Seems to work! Excellent, thanks. This should help those who run automated accessibility testing to have one less issue to get flagged. Thanks for this great module.
Comment #6
ahebrank commentedComment #7
ahebrank commentedMerged and tagged as 2.2