Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#12 ksnip_20221001-164701.png13.16 KBmurz
#2 Снимок экрана от 2021-11-24 19-04-57.png2.16 KBdewalt

Issue fork external_link_popup-3251041

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Eashwar created an issue. See original summary.

dewalt’s picture

dewalt commented
StatusFileSize
new Снимок экрана от 2021-11-24 19-04-57.png2.16 KB

Hi Eashwar,

Actually they are translatable, but I found that field labels aren't correct in translation form.

Screenshot

I think its a good chance to improve labels in the scope of the issue.

  • dewalt committed 99dcec3 on 8.x-1.x 
    Issue #3251041 by dewalt: Can't translate the confirm & ok buttons
dewalt’s picture

dewalt commented
Status: Active » Needs review

oleksandrk made their first commit to this issue’s fork.

oleksandrk opened merge request !1

oleksandrk’s picture

oleksandrk commented

@dewalt Hi, checked your commit, seems changes work fine, also I fixed small typo.

  • dewalt committed 7d65b5a on 8.x-1.x authored by oleksandrk 
    Issue #3251041: Can't translate the confirm & ok buttons
dewalt’s picture

dewalt commented

@oleksandrk thanks, merged

dewalt’s picture

dewalt commented
Status: Needs review » Reviewed & tested by the community
murz’s picture

murz
Primary language English
Location Yerevan, Armenia
commented
Status: Reviewed & tested by the community » Fixed

The changes are committed already. I've rechecked this and the translation of the "OK" and "Cancel" buttons works well. So marking this as fixed.

murz’s picture

murz
Primary language English
Location Yerevan, Armenia
commented
StatusFileSize
new ksnip_20221001-164701.png13.16 KB

Attaching a screenshot with the translated popup.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.