Problem/Motivation

Syntax error, unexpected ')' in /app/build/html/modules/contrib/modal_page/src/Form/ModalForm.php on line 66

Environment:
- PHP 7.0.33
- Lando v3.0.25
- Drupal 8.9.19

Steps to reproduce

Delete the comma in the last element of return statement (line 65).

From

return new static(
      $container->get('language_manager'),
      $container->get('config.factory'),
      $container->get('renderer'),
      $container->get('modal_page.modals'),
);

to

return new static(
      $container->get('language_manager'),
      $container->get('config.factory'),
      $container->get('renderer'),
      $container->get('modal_page.modals')
);

Proposed resolution

Apply the patch below

Comments

Gaston Almeda created an issue. See original summary.

Gaston Almeda’s picture

StatusFileSize
new430 bytes
Gaston Almeda’s picture

Issue summary: View changes
renatog’s picture

Version: 4.1.7 » 4.1.x-dev
Status: Patch (to be ported) » Reviewed & tested by the community

Really makes sense.

Thanks for that

  • paulocs committed e76de51 on 4.1.x authored by Gaston Almeda
    Issue #3249502 by Gaston Almeda: ParseError: syntax error, unexpected...
paulocs’s picture

Thank you!

paulocs’s picture

Assigned: Gaston Almeda » Unassigned
Status: Reviewed & tested by the community » Fixed
renatog’s picture

Thank you so much, Paulo!

I think we can go with a new release for this, what do you think?

paulocs’s picture

New release created: https://www.drupal.org/project/modal_page/releases/4.1.8

:)

Cheers, Paulo.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.