Problem/Motivation
Syntax error, unexpected ')' in /app/build/html/modules/contrib/modal_page/src/Form/ModalForm.php on line 66
Environment:
- PHP 7.0.33
- Lando v3.0.25
- Drupal 8.9.19
Steps to reproduce
Delete the comma in the last element of return statement (line 65).
From
return new static(
$container->get('language_manager'),
$container->get('config.factory'),
$container->get('renderer'),
$container->get('modal_page.modals'),
);
to
return new static(
$container->get('language_manager'),
$container->get('config.factory'),
$container->get('renderer'),
$container->get('modal_page.modals')
);
Proposed resolution
Apply the patch below
Comments
Comment #2
Gaston Almeda commentedComment #3
Gaston Almeda commentedComment #4
renatog commentedReally makes sense.
Thanks for that
Comment #6
paulocsThank you!
Comment #7
paulocsComment #8
renatog commentedThank you so much, Paulo!
I think we can go with a new release for this, what do you think?
Comment #9
paulocsNew release created: https://www.drupal.org/project/modal_page/releases/4.1.8
:)
Cheers, Paulo.