Problem/Motivation

In field.html.twig the visually-hidden class is never applied. This happens because the class is added when label_hidden is true, but when that happens the label is not rendered at all.

Steps to reproduce

Configure a field with the display mode for a label on "Visually hidden". Notice the visually-hidden class is not applied and the label is still visible.

Proposed resolution

Apply the visually-hidden class based on the label_display variable instead of the label_hidden variable (as it was in previous versions of this module).

CommentFileSizeAuthor
#2 3249066-2.patch393 bytestimohuisman

Comments

timohuisman created an issue. See original summary.

timohuisman’s picture

timohuisman
Primary language Dutch
Location Leiden, Netherlands
commented
StatusFileSize
new 3249066-2.patch393 bytes

Applied the proposed resolution (basically reverted how it worked in version 1 & 2).

timohuisman’s picture

timohuisman
Primary language Dutch
Location Leiden, Netherlands
commented
Status: Active » Needs review

  • timohuisman committed 0f6c7cc on 8.x-3.x 
    Issue #3249066 by timohuisman: visually-hidden class not applied on...
timohuisman’s picture

timohuisman
Primary language Dutch
Location Leiden, Netherlands
commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.