Problem/Motivation
This project comes with a composer.json that has a number of problems. The one included in the latest tagged release works, but there so much that is not correct when the repo lives on Drupal.org (and not github). These are things that doesn't stop it from working, but it may cause problems later on.
The problems I've identified are these are these:
- To be downloaded from the Drupal repo the vendor should be "drupal".
- The "license key refers to a deprecated SPDX license identifier.
- The "homepage" points to a non-existing URL.
- The "keywords", "minimum-stability", "repositories" and "require" keys are not needed, and the value convey no additional information.
Since the project has no external dependencies, it is not needed at all, and can just be removed.
Proposed resolution
Remove the file composer.json from the project, or fix the problems.
I strongly favour removing it, but I am going to upload a patch where the problems are fixed. If you want to keep it, it need to be correct.
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | filename_transliteration-3247158-2.patch | 684 bytes | gisle |
Comments
Comment #2
gisleIf you don't remove it altogether, here is a patch to fix it.
Comment #3
gislePlease review the patch.
Comment #5
jwilson3Fixed in release 1.0.3 by just completely removing the file. I also removed the License file, which is already assumed to be GPL and is provided by Drupal.org repo hosting and packagist.