Problem/Motivation

Looking at MigrateSkipRowException, you might think you can throw it anywhere in a migration.

However, for instance, throwing it in a destination plugin causes an error. It looks like it's caught in:

- processing a row
- invoking migrate_prepare_row() hooks
- MigrationLookup -- which might be because that involves processing a row?

Steps to reproduce

Proposed resolution

Add documentation to the exception class docblock.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Issue fork drupal-3247040

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

joachim created an issue. See original summary.

quietone’s picture

Issue tags: +migrate

Yes, making this clear would be an improvement.

Adding tag for migrate maintainers

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

quietone’s picture

Component: documentation » migration system
Issue tags: -migrate

I don't know why I didn't move this to the migration system, that is where the migrate maintainers work from.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

_shY made their first commit to this issue’s fork.

_shy’s picture

Status: Active » Needs review

Updated docblock for MigrateSkipRowException class.

smustgrave’s picture

Status: Needs review » Needs work
Issue tags: +Needs Review Queue Initiative

Left a small comment. Thoughts?

_shy’s picture

I found a variant from the quietone more descriptive, so I decided to go in this way.
Let's discuss it =)

_shy’s picture

Status: Needs work » Needs review
smustgrave’s picture

Status: Needs review » Reviewed & tested by the community

@quietone knows more about the migration system then myself so would go with that suggestion.

_shy’s picture

Hi guys!
Do we have some things that still should be done here?

mikelutz’s picture

Category: Bug report » Task
_shy’s picture

Updated MR.

quietone’s picture

I'm triaging RTBC issues. I read the IS and the comments. I didn't find any unanswered questions or other work to do.

I was considering committing this but it is using my wording for the comment so it will be best for another committer to check this.

longwave’s picture

Version: 11.x-dev » 10.2.x-dev
Status: Reviewed & tested by the community » Fixed

Backported as a docs-only fix to 10.2.x.

Committed and pushed e03d3ec549 to 11.x and 290d8a420d to 10.2.x. Thanks!

  • longwave committed 290d8a42 on 10.2.x
    Issue #3247040 by _shY, quietone, smustgrave, joachim:...

  • longwave committed e03d3ec5 on 11.x
    Issue #3247040 by _shY, quietone, smustgrave, joachim:...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.