Problem/Motivation
Looking at MigrateSkipRowException, you might think you can throw it anywhere in a migration.
However, for instance, throwing it in a destination plugin causes an error. It looks like it's caught in:
- processing a row
- invoking migrate_prepare_row() hooks
- MigrationLookup -- which might be because that involves processing a row?
Steps to reproduce
Proposed resolution
Add documentation to the exception class docblock.
Remaining tasks
User interface changes
API changes
Data model changes
Release notes snippet
Issue fork drupal-3247040
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
- 3247040-migrateskiprowexception-should-document
changes, plain diff MR !4150
Comments
Comment #2
quietone commentedYes, making this clear would be an improvement.
Adding tag for migrate maintainers
Comment #6
quietone commentedI don't know why I didn't move this to the migration system, that is where the migrate maintainers work from.
Comment #10
_shyUpdated docblock for
MigrateSkipRowExceptionclass.Comment #11
smustgrave commentedLeft a small comment. Thoughts?
Comment #12
_shyI found a variant from the quietone more descriptive, so I decided to go in this way.
Let's discuss it =)
Comment #13
_shyComment #14
smustgrave commented@quietone knows more about the migration system then myself so would go with that suggestion.
Comment #15
_shyHi guys!
Do we have some things that still should be done here?
Comment #16
mikelutzComment #17
_shyUpdated MR.
Comment #18
quietone commentedI'm triaging RTBC issues. I read the IS and the comments. I didn't find any unanswered questions or other work to do.
I was considering committing this but it is using my wording for the comment so it will be best for another committer to check this.
Comment #19
longwaveBackported as a docs-only fix to 10.2.x.
Committed and pushed e03d3ec549 to 11.x and 290d8a420d to 10.2.x. Thanks!