Problem/Motivation

  • Should clarify dependencies/order of running feature files by files themselves.
  • Should have no subdirectories (admin & user) as the feature files has "Admin" and "User" suffix and dependencies exist across admin and user files.
  • Better to locate feature files using template to /templates directory
  • Should align with case sensitive names of AWS resources

Issue fork cloud-3246489

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

kumikoono created an issue. See original summary.

kumikoono opened merge request !486

kumikoono’s picture

kumikoono commented
Status: Active » Needs review

kumikoono closed merge request !486

kumikoono opened merge request !500

kumikoono’s picture

kumikoono commented
Status: Needs review » Active
kumikoono’s picture

kumikoono commented
Status: Active » Needs review

@yas Can you review?

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Needs work

@kumikoono

Changed to Needs work. As per our offline discussion, each filename starts AWS-ATDD-00- as a prefix and 00 as a minimal test scenarios

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Title: Rename/relocate/fix BDD test feature files » Refactor Behat feature files
kumikoono’s picture

kumikoono commented
Status: Needs work » Needs review

@yas Updated. Can you review? Thx!

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Needs work

@kumikoono

Thank you for the update. Can you add a prefix CLOUD- to the filename ATDD-00-01-AdminCheckCleanState.feature? It will become CLOUD-ATDD-00-01-AdminCheckCleanState.feature.

kumikoono’s picture

kumikoono commented
Status: Needs work » Needs review

@yas Renamed the feature file. Can you review? Thanks!

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Reviewed & tested by the community

@kumikoono

Thank you for the update. The patch looks good to me now. I'll merge the patch to 4.x and close this issue as Fixed.

  • yas committed 7cad306 on 4.x authored by kumikoono 
    Issue #3246489 by kumikoono, yas: Refactor Behat feature files

yas closed merge request !500

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.