Problem/Motivation

In some projects it might be wanted not to track 404 and 403 resources.

Proposed resolution

Make the default behaviour configurable.

Issue fork matomo-3245705

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

tasc created an issue. See original summary.

tasc opened merge request !15

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Version: 8.x-1.12 » 8.x-1.x-dev
grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Status: Active » Needs work
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented

There are some issues with the configuration schema, which causes two errors in the testing. One of those is the following one.

Drupal\Tests\matomo\Functional\MatomoUninstallTest::testMatomoUninstall
Drupal\Core\Config\Schema\SchemaIncompleteException: Schema errors for matomo.settings with the following errors: matomo.settings:status_codes_disabled missing schema

tasc’s picture

tasc
Primary language German
Location Berlin
commented

Thanks Alberto for pointing me the direction!
I had no idea and also some difficulties setting up a test-instance :/

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Needs work » Needs review
grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Status: Needs review » Needs work

Hello,

One small change to do after review.

Note: I have not yet tested the MR locally, only reviewing it.

grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Status: Needs work » Needs review

Thanks for the update MR.

Please post a comment in the issue because there is no email notification when an MR or code review is updated.

Also issue status should had been updated.

I will try to give a look.

grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Assigned: Unassigned » grimreaper

  • Grimreaper committed dc9773f on 8.x-1.x 
    Issue #3245705 by tasc, Grimreaper, apaderno: Make tracking of 404/403...
  • Grimreaper committed e3eefcd on 8.x-1.x authored by tasc
    Issue #3245705 by tasc, Grimreaper, apaderno: Make tracking of 404/403...
grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Assigned: grimreaper » Unassigned
Status: Needs review » Fixed

Merged.

Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.