Problem/Motivation

  • Write a README.md for running Behat
CommentFileSizeAuthor
#23 3244469-22-hotfix.patch9.5 KByas
#21 3244469-21-hotfix.patch9.57 KByas

Issue fork cloud-3244469

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

yutong.li created an issue. See original summary.

yutong.li credited kumikoono.

yutong.li credited yas.

yutong.li’s picture

yutong.li commented

yutong.li opened merge request !461

yutong.li’s picture

yutong.li commented
Assigned: Unassigned » yutong.li
yutong.li’s picture

yutong.li commented
Status: Active » Needs review
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Needs work

@yutong.li

Thank you for adding the README.md. I posted my comments. Could you please check it? Thanks!

yutong.li’s picture

yutong.li commented
Status: Needs work » Needs review
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Needs work

@yutong.li

Thank you for the update. I have one more comment above after you separated the patch file. Thanks!

yutong.li’s picture

yutong.li commented
Status: Needs work » Needs review
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Needs work

@yutong.li

Thank you for the update. I posted my comments above. Thanks!

yutong.li’s picture

yutong.li commented
Status: Needs work » Needs review
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Issue summary: View changes
Status: Needs review » Needs work

@yutong.li

Thank you for the update. Could you please fix the following coding standard violations? Thanks!

$ ./vendor/bin/phpcs --standard=Drupal --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml "${CODE_DIR}"
FILE: /builds/docomoinnovations/cloud/tests/src/Behat/README.md
----------------------------------------------------------------------
FOUND 1 ERROR AND 21 WARNINGS AFFECTING 22 LINES
----------------------------------------------------------------------
   5 | WARNING | [ ] Line exceeds 80 characters; contains 84
     |         |     characters
  10 | WARNING | [ ] Line exceeds 80 characters; contains 85
     |         |     characters
  12 | WARNING | [ ] Line exceeds 80 characters; contains 85
     |         |     characters
  18 | WARNING | [ ] Line exceeds 80 characters; contains 83
     |         |     characters
  26 | WARNING | [ ] Line exceeds 80 characters; contains 82
     |         |     characters
  27 | WARNING | [ ] Line exceeds 80 characters; contains 86
     |         |     characters
  34 | WARNING | [ ] Line exceeds 80 characters; contains 88
     |         |     characters
  36 | WARNING | [ ] Line exceeds 80 characters; contains 96
     |         |     characters
  37 | WARNING | [ ] Line exceeds 80 characters; contains 84
     |         |     characters
  38 | WARNING | [ ] Line exceeds 80 characters; contains 86
     |         |     characters
  44 | WARNING | [ ] Line exceeds 80 characters; contains 86
     |         |     characters
  47 | WARNING | [ ] Line exceeds 80 characters; contains 91
     |         |     characters
  48 | WARNING | [ ] Line exceeds 80 characters; contains 86
     |         |     characters
  99 | WARNING | [ ] Line exceeds 80 characters; contains 98
     |         |     characters
 108 | WARNING | [ ] Line exceeds 80 characters; contains 85
     |         |     characters
 109 | WARNING | [ ] Line exceeds 80 characters; contains 82
     |         |     characters
 118 | WARNING | [ ] Line exceeds 80 characters; contains 87
     |         |     characters
 137 | WARNING | [ ] Line exceeds 80 characters; contains 113
     |         |     characters
 147 | WARNING | [ ] Line exceeds 80 characters; contains 82
     |         |     characters
 148 | WARNING | [ ] Line exceeds 80 characters; contains 85
     |         |     characters
 176 | WARNING | [ ] Line exceeds 80 characters; contains 82
     |         |     characters
 181 | ERROR   | [x] Expected 1 newline at end of file; 0 found
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------
Time: 32.69 secs; Memory: 54.01MB
yutong.li’s picture

yutong.li commented
Status: Needs work » Needs review
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Reviewed & tested by the community

@yutong.li

Thank you for the update. It looks good. I'll merge the patch to 4.x and close this issue as Fixed.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Title: Write a README.md for running Behat » Add a README.md for running Behat

  • yas committed d221bd7 on 4.x authored by yutong.li 
    Issue #3244469 by yutong.li, yas, kumikoono: Add a README.md for running...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed

yas closed merge request !461

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Fixed » Needs review
StatusFileSize
new 3244469-21-hotfix.patch9.57 KB

@yutong.li

Providing a patch to align the indents for the formats for cosmetics.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Reviewed & tested by the community

The test has been passed successfully, so I'll merge the patch to 4.x and close this issue as Fixed.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new 3244469-22-hotfix.patch9.5 KB

Found the trailing whitespaces

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Reviewed & tested by the community

The test has been passed successfully, so I'll merge the patch to 4.x and close this issue as Fixed.

  • yas committed 3510766 on 4.x 
    Issue #3244469 by yas: Hotfix - Add a README.md for running Behat
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.