Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.Problem/Motivation
API response property page is ambiguously named and is conflicting with nuxt parameter.
"page": "layout--default",
Proposed resolution
1. rename page to page_layout and remove page_layout that is nested under settings.
2. breadcrumbs_html property is not needed anymore.
API changes
Top level property name is changed
page ---> page_layout
Issue fork lupus_ce_renderer-3244329
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
- 3244329-api-response-has
changes, plain diff MR !10 - 2.x changes, plain diff MR !11
Comments
Comment #4
fagolupus_ce_renderer does not add page_layout under settings, so there is no duplication here.
However, yes I can see problems with the current "page" attribute:
- it's weirdly named and not currently used
- I agree that page_layout with value "default" is much better than having a page of "layout--default"
but then it does not make sense to make this markup only, why does the json serialization not get the attribute?
Finally, there is a breadcrumbs_html attribute next to it - I think this should be deprecated and removed as well. It's a thing of the past (lupus-frontproxy) which is unlikely to be useful by anyone else, drupal-ce connector does not use it either. Let's drop it as long as we are in beta here!
So the issue description, patch needs some work. Finally we need to prepare change-record draft here which describes the API change. Please look at existing ones for guidance.
Comment #5
useernamee commentedComment #7
useernamee commentedThis change record applies to current issue: https://www.drupal.org/node/3245112
Comment #9
fagook, updated issue title and merged it.