Problem/Motivation

Refresh related entities in worker site after running operations from master (vmware)

> Also, I think we should add some error handling logic when getShortEntityTypeNamePluralCamelByTypeName() returns NULL in the other places, but we should create another issue for the refactoring.

Yes, I agree with you.

Issue fork cloud-3243034

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Xiaohua Guan created an issue. See original summary.

Xiaohua Guan opened merge request !450

xiaohua guan’s picture

xiaohua guan commented
Status: Active » Needs review

@yas

Please review the commit. Thanks.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Needs work

@xiaohua-guan

Thank you for the patch. Could you please fix the coding standard violation?

https://www.drupal.org/pift-ci-job/2204939

Also, I think we should add some error handling logic when getShortEntityTypeNamePluralCamelByTypeName() returns NULL in the other places, but we should create another issue for the refactoring.

xiaohua guan’s picture

xiaohua guan commented
Issue summary: View changes
Status: Needs work » Needs review

@yas

Thanks for your review. I've fixed the code violation.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Reviewed & tested by the community

@xiaohua-guan

Thank you for the update. I'll merge the patch to 4.x and close this issue as Fixed.

  • yas committed d7a9840 on 4.x authored by Xiaohua Guan 
    Issue #3243034 by Xiaohua Guan, yas: Refresh related entities in worker...

yas closed merge request !450

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.